-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Mailgun #8056
🎉 New Source: Mailgun #8056
Conversation
@sergei-solonitcyn could you please run it through internal review first? |
airbyte-integrations/connectors/source-mailgun/integration_tests/configured_catalog.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailgun/source_mailgun/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comments.
Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com>
"domain_region": { | ||
"type": "string", | ||
"description": "Domain region code. 'EU' or 'US' are possible values. The default is 'US'.", | ||
"title": "Domain Region Code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, if there are only two possible values this can be an enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergei-solonitcyn did you see the comment on the other PR about publishing the CDK? it needs to be published for this to work
Also, please make sure to update the PR template when submitting PRs
/test connector=connectors/source-mailgun
|
/publish connector=connectors/source-mailgun
|
Added to connector index Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com>
…-airbyte-native-mailgun
@sherifnada everything is tested and published now. |
* airbyte-6172 New Source: Airbyte-native Mailgun Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com> Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>
What
Create new source for Mailgun
#6172
Pre-merge Checklist
New Connector
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here