Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Mailgun #8056

Conversation

sergei-solonitcyn
Copy link
Contributor

@sergei-solonitcyn sergei-solonitcyn commented Nov 17, 2021

What

Create new source for Mailgun
#6172

Pre-merge Checklist

New Connector

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 17, 2021
@sherifnada
Copy link
Contributor

@sergei-solonitcyn could you please run it through internal review first?

@sherifnada sherifnada requested review from avida and keu November 17, 2021 22:13
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets November 18, 2021 22:07 Inactive
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets November 18, 2021 22:13 Inactive
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets November 18, 2021 22:18 Inactive
@sergei-solonitcyn sergei-solonitcyn marked this pull request as draft November 19, 2021 07:49
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comments.

@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets November 20, 2021 23:36 Inactive
@sergei-solonitcyn sergei-solonitcyn changed the title Draft: Sergei solonitcyn/airbyte 6172 new source airbyte native mailgun Sergei solonitcyn/airbyte 6172 new source airbyte native mailgun Nov 24, 2021
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets November 24, 2021 06:27 Inactive
@sergei-solonitcyn sergei-solonitcyn marked this pull request as ready for review November 24, 2021 06:40
@sergei-solonitcyn sergei-solonitcyn linked an issue Nov 24, 2021 that may be closed by this pull request
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets December 6, 2021 01:13 Inactive
Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com>
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets December 6, 2021 01:18 Inactive
@sergei-solonitcyn sergei-solonitcyn changed the title Sergei solonitcyn/airbyte 6172 new source airbyte native mailgun New Source: Airbyte-native Mailgun Dec 6, 2021
Comment on lines +16 to +19
"domain_region": {
"type": "string",
"description": "Domain region code. 'EU' or 'US' are possible values. The default is 'US'.",
"title": "Domain Region Code"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, if there are only two possible values this can be an enum

Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergei-solonitcyn did you see the comment on the other PR about publishing the CDK? it needs to be published for this to work

Also, please make sure to update the PR template when submitting PRs

@sergei-solonitcyn sergei-solonitcyn changed the title New Source: Airbyte-native Mailgun New Source: Mailgun Dec 7, 2021
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 08:36 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 08:36 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 09:10 Inactive
@sergei-solonitcyn
Copy link
Contributor Author

sergei-solonitcyn commented Dec 7, 2021

/test connector=connectors/source-mailgun

🕑 connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/1548679358
✅ connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/1548679358
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_mailgun/__init__.py       2      0   100%
	 source_mailgun/source.py       104      4    96%
	 ------------------------------------------------
	 TOTAL                          106      4    96%

@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 09:15 Inactive
@sergei-solonitcyn
Copy link
Contributor Author

sergei-solonitcyn commented Dec 7, 2021

/publish connector=connectors/source-mailgun

🕑 connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/1548733133
✅ connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/1548733133

@jrhizor jrhizor temporarily deployed to more-secrets December 7, 2021 09:29 Inactive
Added to connector index

Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com>
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets December 7, 2021 10:57 Inactive
@sergei-solonitcyn sergei-solonitcyn temporarily deployed to more-secrets December 7, 2021 11:05 Inactive
@sergei-solonitcyn sergei-solonitcyn removed the request for review from avida December 7, 2021 11:23
@sergei-solonitcyn
Copy link
Contributor Author

@sherifnada everything is tested and published now.

@keu keu changed the title New Source: Mailgun 🎉 New Source: Mailgun Dec 7, 2021
@sergei-solonitcyn sergei-solonitcyn merged commit ccf8eeb into master Dec 7, 2021
@sergei-solonitcyn sergei-solonitcyn deleted the sergei-solonitcyn/airbyte-6172__new-source-airbyte-native-mailgun branch December 7, 2021 16:04
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* airbyte-6172 New Source: Airbyte-native Mailgun

Signed-off-by: Sergei Solonitcyn <sergei.solonitcyn@zazmic.com>

Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Source: Airbyte-native Mailgun
6 participants