-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added access_token authorization method #8058
Conversation
Hello @sujitsagar the PR #7086 is already adding OAuth for Zendesk support, there is anything blocking you with this change? @antixar for your info |
Hi @marcosmarxm, yes, its a blocker for us. We can support only Access Token based authorizer for this connector. Enabling it sooner would help us a lot. cc: @antixar |
minor correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oAuth2.0 is ready but the Airbyte UI part is not completed for its using. Later your correction will be converted to an oAuth 2.0 button for full oAuth2 flow.
Thanks @antixar. Can I contribute for Airbyte UI part as well? |
/test connector=connectors/source-zendesk-support
|
@sujitsagar ,thank you for your activity but UI part has already been being developing now. |
@sujitsagar , could you upgrade to the latest version and test the new auth method? |
@antixar I have upgraded and tried this patch. It works great. |
…rbytehq#8058) * Added access_token authorization method * Update spec.json minor correction * Update spec.json * Update source_definitions.yaml * Update 79c1aa37-dae3-42ae-b333-d1c105477715.json * Update Dockerfile * Update acceptance-test-config.yml * Update zendesk-support.md Co-authored-by: Maksym Pavlenok <antixar@gmail.com>
…ytehq#8204) * update spec file Co-authored-by: Sujit Sagar <contact@sujitsagar.com>
What
The problem was that zendesk access_token auth was not available
How
I have added Access Token option in the allowed authorization methods
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes