Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added access_token authorization method #8058

Merged
merged 11 commits into from
Nov 23, 2021
Merged

Conversation

sujitsagar
Copy link
Contributor

What

The problem was that zendesk access_token auth was not available

How

I have added Access Token option in the allowed authorization methods

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨


Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 17, 2021
@marcosmarxm
Copy link
Member

Hello @sujitsagar the PR #7086 is already adding OAuth for Zendesk support, there is anything blocking you with this change? @antixar for your info

@sujitsagar
Copy link
Contributor Author

Hi @marcosmarxm, yes, its a blocker for us. We can support only Access Token based authorizer for this connector. Enabling it sooner would help us a lot.

cc: @antixar

Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oAuth2.0 is ready but the Airbyte UI part is not completed for its using. Later your correction will be converted to an oAuth 2.0 button for full oAuth2 flow.

@sujitsagar
Copy link
Contributor Author

Thanks @antixar. Can I contribute for Airbyte UI part as well?
Can you please point me relevant folder/file? I will make necessary changes.

@antixar
Copy link
Contributor

antixar commented Nov 23, 2021

/test connector=connectors/source-zendesk-support

Error: No ref found for: patch-1

@antixar antixar temporarily deployed to more-secrets November 23, 2021 10:17 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 23, 2021
@antixar
Copy link
Contributor

antixar commented Nov 23, 2021

@sujitsagar ,thank you for your activity but UI part has already been being developing now.
I've corrected your PR a bit.
@marcosmarxm please help me to merge this PR to master.

@antixar antixar temporarily deployed to more-secrets November 23, 2021 13:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 13:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 14:06 Inactive
@antixar antixar merged commit 99ad4e5 into airbytehq:master Nov 23, 2021
antixar added a commit that referenced this pull request Nov 23, 2021
* update spec file
Co-authored-by: Sujit Sagar <contact@sujitsagar.com>
@antixar
Copy link
Contributor

antixar commented Nov 23, 2021

@sujitsagar , could you upgrade to the latest version and test the new auth method?

@sujitsagar
Copy link
Contributor Author

@antixar I have upgraded and tried this patch. It works great.
Thank you for your support.
cc: @marcosmarxm

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…rbytehq#8058)

* Added access_token authorization method

* Update spec.json

minor correction

* Update spec.json

* Update source_definitions.yaml

* Update 79c1aa37-dae3-42ae-b333-d1c105477715.json

* Update Dockerfile

* Update acceptance-test-config.yml

* Update zendesk-support.md

Co-authored-by: Maksym Pavlenok <antixar@gmail.com>
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…ytehq#8204)

* update spec file
Co-authored-by: Sujit Sagar <contact@sujitsagar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants