Add Singer Facebook Source #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Nov 4, 2020
airbyte-integrations/connectors/source-facebook-marketing-api-singer/Dockerfile
Outdated
Show resolved
Hide resolved
airbyte-integrations/bases/base-singer/base_singer/singer_helpers.py
Outdated
Show resolved
Hide resolved
cgardens
approved these changes
Nov 4, 2020
airbyte-integrations/connectors/source-facebook-marketing-api-singer/Dockerfile.test
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing-api-singer/README.md
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing-api-singer/README.md
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing-api-singer/README.md
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing-api-singer/README.md
Outdated
Show resolved
Hide resolved
| command = "install .[tests]" | ||
| } | ||
|
|
||
| task unitTest(type: PythonTask){ |
There was a problem hiding this comment.
when do we use this versus command = "setup.py test"? it seems like we do both things.
There was a problem hiding this comment.
we only give guidance to use pytest (or python -m pytest, they're 99% equivalent) now because setup.py test is deprecated.
airbyte-integrations/connectors/source-facebook-marketing-api-singer/requirements.txt
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing-api-singer/setup.py
Outdated
Show resolved
Hide resolved
...nnectors/source-facebook-marketing-api-singer/source_facebook_marketing_api_singer/spec.json
Outdated
Show resolved
Hide resolved
…singer/setup.py Co-authored-by: Charles <giardina.charles@gmail.com>
|
@cgardens I used the dev-tier access token to run tests. But it is very throttled. The cap varies based on which resource we're hitting but we're basically going to hit after a couple of PRs per hour. I'm applying to the better access tier today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the FB singer-based source.
Accompanying docs are in #809
I'm not adding this to PR tests because FB heavily throttles the default token type. We have to apply for access to get the least-throttled token type, which is currently in progress.
checklist