Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帀 Zendesk Connector: Adds TicketMetricEvents #8168

Conversation

jonoirwinrsa
Copy link
Contributor

@jonoirwinrsa jonoirwinrsa commented Nov 22, 2021

What

Zendesk is missing some useful tables and fields. This adds Ticket Event Metrics which is useful when dealing with SLA breaches.

Related AirByte issue can be found here: #8168

How

Adds ticket_metric_events to the schema

馃毃 User Impact 馃毃

There shouldn't be any breaking changes. This only adds another table.

NB: Potential issue

The time field has been used as the cursor for this schema. I am not sure if that works as I have intended it?
I attempted to generate/use generated_timestamp without any luck

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 22, 2021
@jonoirwinrsa jonoirwinrsa changed the title feat: adds stream config for TicketMetricEvents Zendesk Connector: Adds TicketMetricEvents Nov 22, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 23, 2021
@jonoirwinrsa jonoirwinrsa marked this pull request as ready for review November 23, 2021 12:07
@jonoirwinrsa jonoirwinrsa changed the title Zendesk Connector: Adds TicketMetricEvents 馃帀 Zendesk Connector: Adds TicketMetricEvents Nov 24, 2021
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @jonoirwinrsa. I don't have access to your branch to made some small edits (solve conflicts and tests) so I'll publish and merge your code using my PR #8316.

@marcosmarxm
Copy link
Member

thanks for the contribution @jonoirwinrsa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants