Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to pass two_sequential_reads test and skip test state_with_abnormally_large_values #8264

Merged

Conversation

augan-rymkhan
Copy link
Contributor

@augan-rymkhan augan-rymkhan commented Nov 26, 2021

What

Two acceptance tests fail for Source Google Analytics v4. The cause is described here

How

  1. To fix the case where two_sequential_reads test fails, limit the slice range with end_date: end_date_slice = min(end_date_slice, end_date)
  2. To skip the test_state_with_abnormally_large_values test, comment future_state_path in acceptance-test-config.yaml for temporarily not to block publishing.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 26, 2021
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 07:04 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 10:24 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 11:32 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 11:49 Inactive
@augan-rymkhan augan-rymkhan changed the title Commented incremental tests to skip them in SAT Fix to pass two_sequential_reads test and skip test state_with_abnormally_large_values Nov 26, 2021
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 14:26 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 26, 2021 14:54 Inactive
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests

@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 29, 2021 05:46 Inactive
@augan-rymkhan
Copy link
Contributor Author

Please add unit tests

@avida Done.

@augan-rymkhan augan-rymkhan linked an issue Nov 30, 2021 that may be closed by this pull request
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 30, 2021
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 30, 2021 09:57 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets November 30, 2021 14:23 Inactive
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Dec 1, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1524151012
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1524151012
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       239     62    74%
	 ------------------------------------------------------------
	 TOTAL                                      241     62    74%

@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 04:19 Inactive
@@ -1,5 +1,10 @@
# See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests

# The 'future_state_path' field is commented out to skip the test `test_state_with_abnormally_large_values`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the comment, next engineer reading the code will be very thankful 💪🏼

@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Dec 2, 2021

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1529029754
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1529029754

@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 04:21 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets December 2, 2021 04:37 Inactive
@augan-rymkhan augan-rymkhan merged commit 3afb39d into master Dec 2, 2021
@augan-rymkhan augan-rymkhan deleted the arymkhan/skip_incremental_sat_tests_google_analytics branch December 2, 2021 04:38
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…ally_large_values (airbytehq#8264)

* Commented incremental tests to skip them in SAT

* limit the slice range with end_date

* added unit tests for stream_slices

* changed the connector version

* changed reason of the comment yml

* use freezgun in unit tests

* formatted code

* updated version in spec yaml

Co-authored-by: Auganbay <auganenu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Google Analytics: two acceptance tests fail
6 participants