-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to pass two_sequential_reads test and skip test state_with_abnormally_large_values #8264
Fix to pass two_sequential_reads test and skip test state_with_abnormally_large_values #8264
Conversation
airbyte-integrations/connectors/source-google-analytics-v4/acceptance-test-config.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests
@avida Done. |
airbyte-integrations/connectors/source-google-analytics-v4/unit_tests/unit_test.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes
/test connector=connectors/source-google-analytics-v4
|
@@ -1,5 +1,10 @@ | |||
# See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) | |||
# for more information about how to configure these tests | |||
|
|||
# The 'future_state_path' field is commented out to skip the test `test_state_with_abnormally_large_values` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the comment, next engineer reading the code will be very thankful 💪🏼
/publish connector=connectors/source-google-analytics-v4
|
…ally_large_values (airbytehq#8264) * Commented incremental tests to skip them in SAT * limit the slice range with end_date * added unit tests for stream_slices * changed the connector version * changed reason of the comment yml * use freezgun in unit tests * formatted code * updated version in spec yaml Co-authored-by: Auganbay <auganenu@gmail.com>
What
Two acceptance tests fail for Source Google Analytics v4. The cause is described here
How
two_sequential_reads
test fails, limit the slice range with end_date:end_date_slice = min(end_date_slice, end_date)
test_state_with_abnormally_large_values
test, commentfuture_state_path
inacceptance-test-config.yaml
for temporarily not to block publishing.Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes