Postgres normalization #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
approved these changes
Nov 6, 2020
| @@ -43,7 +43,7 @@ | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(DefaultNormalizationRunner.class); | |||
|
|
|||
| public static final String NORMALIZATION_IMAGE_NAME = "airbyte/normalization:0.1.0"; | |||
| public static final String NORMALIZATION_IMAGE_NAME = "airbyte/normalization:dev"; | |||
There was a problem hiding this comment.
Shouldn't this be in some config files or based on env variables so we can switch from dev mode to prod easily or something?
| {% macro json_extract(json_column, json_path) -%} | ||
| {{ adapter.dispatch('json_extract')(json_column, json_path) }} | ||
| {% macro json_extract(json_column, json_path_list) -%} | ||
| {{ adapter.dispatch('json_extract')(json_column, format_path(json_path_list)) }} |
There was a problem hiding this comment.
This is the call to the adapter.dispatch function, it shouldn't need to make the call to format_path right?
(you didn't do so on the other variants of the macro either)
There was a problem hiding this comment.
correct, I think it shouldn't need a format_path call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remaining items
PostgresDestination.java#closefor context on how we replace tables.