Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Mixpanel: fix for discovery command takes a very long time #8381

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Dec 1, 2021

What

From OnCall Repo:
#8321

How

  • changed the reqs_per_hour_limit value to 0 when we run the process of fetching dynamic properties from endpoint.
  • edited the parse_response to handle these cases.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Dec 1, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 1, 2021
@bazarnov bazarnov linked an issue Dec 1, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 1, 2021
@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 1, 2021

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1525900300
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1525900300
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  945    441    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_mixpanel/__init__.py       2      0   100%
	 source_mixpanel/source.py       298    176    41%
	 -------------------------------------------------
	 TOTAL                           300    176    41%

@bazarnov bazarnov temporarily deployed to more-secrets December 1, 2021 13:08 Inactive
@bazarnov bazarnov changed the title 🐛 Source Mixpanel: fix fordiscovery command takes a very long time 🐛 Source Mixpanel: fix for discovery command takes a very long time Dec 1, 2021
@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 13:10 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 1, 2021 15:28 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 1, 2021

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1526511546
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1526511546
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  945    441    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_mixpanel/__init__.py       2      0   100%
	 source_mixpanel/source.py       299    177    41%
	 -------------------------------------------------
	 TOTAL                           301    177    41%

@bazarnov bazarnov requested review from ChristopheDuong and removed request for sherifnada December 1, 2021 15:33
@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 15:35 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 1, 2021

/publish connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1526619094
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/1526619094

@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 15:59 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 1, 2021 18:07 Inactive
@bazarnov bazarnov merged commit 96081e1 into master Dec 1, 2021
@bazarnov bazarnov deleted the bazarnov/8321-mixpanel-discovery-issues branch December 1, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source mixpanel: discovery command takes a very long time
4 participants