Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner #8425

igrankova · 2021-12-02T09:21:44Z

What

Add title and description properties to each field in source-connectors specifications:
source-smartsheets
source-square
source-strava
source-tiktok-marketing
source-typeform
source-zendesk-chat
source-airtable
source-amazon-seller-partner

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

CLAassistant · 2021-12-02T09:21:49Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ grubberr
✅ igrankova
❌ Your Name

Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

airbyte-integrations/connectors/source-airtable/source_airtable/spec.json

grubberr · 2021-12-02T09:48:38Z

airbyte-integrations/connectors/source-airtable/source_airtable/spec.json

        "airbyte_secret": true,
        "examples": ["key1234567890"]
      },
      "base_id": {
        "type": "string",
-        "description": "The base ID to integrate data from",
+        "description": "The Base ID to integrate the data from",
+		"title": "Base ID",


grubberr · 2021-12-02T09:49:13Z

...-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json

@@ -6,57 +6,57 @@
    "type": "object",
    "properties": {
      "replication_start_date": {
-        "title": "Replication Start Date",
+        "title": "Start Date!",


grubberr · 2021-12-02T16:36:38Z

it seems for 'source_amazon_seller_partner' connector spec.json ignored you need to fix

./airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py

class ConnectorConfig(BaseModel):
    class Config:
        title = "Amazon Seller Partner Spec"

...-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json

grubberr · 2021-12-06T10:12:58Z

/test connector=connectors/source-airtable

🕑 connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/1544109559
❌ connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/1544109559
🐛 https://gradle.com/s/lpwyvgmogpeek

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2021-12-10T09:15:38Z

/publish connector=connectors/source-airtable

🕑 connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/1562717634
✅ connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/1562717634

grubberr · 2021-12-10T09:16:27Z

/publish connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1562720915
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1562720915

grubberr · 2021-12-10T09:17:00Z

/publish connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/1562723126
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/1562723126

grubberr · 2021-12-10T09:18:39Z

/publish connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1562729014
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1562729014

grubberr · 2021-12-10T09:19:38Z

/publish connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1562732551
✅ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/1562732551

grubberr · 2021-12-10T09:20:17Z

/publish connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1562735016
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/1562735016

grubberr · 2021-12-10T09:20:51Z

/publish connector=connectors/source-zendesk-chat

🕑 connectors/source-zendesk-chat https://github.com/airbytehq/airbyte/actions/runs/1562736960
✅ connectors/source-zendesk-chat https://github.com/airbytehq/airbyte/actions/runs/1562736960

grubberr · 2021-12-10T09:22:08Z

/publish connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1562741699
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/1562741699

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

…e, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner (airbytehq#8425) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Your Name <you@example.com>

igrankova added 3 commits November 30, 2021 14:35

Fixed FreshDesk Start Date

c563317

Fields title/description update for issue 8363

d332547

Test commit

5c22036

github-actions bot added the area/connectors Connector related issues label Dec 2, 2021

igrankova self-assigned this Dec 2, 2021

igrankova requested a review from grubberr December 2, 2021 09:25

igrankova linked an issue Dec 2, 2021 that may be closed by this pull request

Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, clickhouse-strict-encrypt, zendesk-talk, airtable, amazon-seller-partner #8363

Closed

grubberr suggested changes Dec 2, 2021

View reviewed changes

Fixed

f2a643b

igrankova temporarily deployed to more-secrets December 2, 2021 09:55 Inactive

Files title/description update for issue 8363

aa24895

igrankova requested a review from grubberr December 2, 2021 11:50

igrankova temporarily deployed to more-secrets December 2, 2021 11:51 Inactive

Versions up for issue 8363

825db7d

igrankova temporarily deployed to more-secrets December 2, 2021 15:45 Inactive

Amazon seller partner updated

3950772

igrankova temporarily deployed to more-secrets December 2, 2021 17:15 Inactive

grubberr reviewed Dec 2, 2021

View reviewed changes

...-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json Show resolved Hide resolved

grubberr approved these changes Dec 3, 2021

View reviewed changes

grubberr requested a review from nataliekwong December 3, 2021 13:15

nataliekwong approved these changes Dec 3, 2021

View reviewed changes

Merge branch 'master' into igrankova/issue-8363-update-title-description

26e1458

jrhizor temporarily deployed to more-secrets December 6, 2021 10:15 Inactive

Changelog added for airtable.md

b202378

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 6, 2021

grubberr temporarily deployed to more-secrets December 6, 2021 10:23 Inactive

- source-amazon-seller-partner 0.2.4 -> 0.2.5

6001d44

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

jrhizor temporarily deployed to more-secrets December 10, 2021 07:51 Inactive

Merge branch 'master' into igrankova/issue-8363-update-title-description

278d980

jrhizor temporarily deployed to more-secrets December 10, 2021 09:17 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 09:18 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 09:20 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 09:21 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 09:22 Inactive

jrhizor temporarily deployed to more-secrets December 10, 2021 09:23 Inactive

source_specs.yaml updated

7271b73

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit ae8acdc into master Dec 10, 2021

grubberr deleted the igrankova/issue-8363-update-title-description branch December 10, 2021 09:58

grubberr temporarily deployed to more-secrets December 10, 2021 09:58 Inactive

igrankova added connectors/source/airtable connectors/sources-api connectors/source/amazon-seller-partner labels Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner #8425

Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner #8425

igrankova commented Dec 2, 2021 •

edited by grubberr

CLAassistant commented Dec 2, 2021 •

edited

grubberr Dec 2, 2021

grubberr Dec 2, 2021

grubberr commented Dec 2, 2021

grubberr commented Dec 6, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner #8425

Update fields in source-connectors specifications: smartsheets, square, strava, tiktok-marketing, typeform, zendesk-chat, airtable, amazon-seller-partner #8425

Conversation

igrankova commented Dec 2, 2021 • edited by grubberr

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

CLAassistant commented Dec 2, 2021 • edited

grubberr Dec 2, 2021

Choose a reason for hiding this comment

grubberr Dec 2, 2021

Choose a reason for hiding this comment

grubberr commented Dec 2, 2021

grubberr commented Dec 6, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

grubberr commented Dec 10, 2021 • edited by github-actions bot

igrankova commented Dec 2, 2021 •

edited by grubberr

CLAassistant commented Dec 2, 2021 •

edited

grubberr commented Dec 6, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot

grubberr commented Dec 10, 2021 •

edited by github-actions bot