Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Refactor Pokeapi Source to CDK #8432

Merged

Conversation

yevhenii-ldv
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv commented Dec 2, 2021

What

resolves #8422.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Dec 2, 2021

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1530742967
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1530742967
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  945    441    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                             Stmts   Miss  Cover
	 ----------------------------------------------------
	 source_pokeapi/__init__.py           2      2     0%
	 source_pokeapi/pokemon_list.py       2      2     0%
	 source_pokeapi/source.py            30     30     0%
	 ----------------------------------------------------
	 TOTAL                               34     34     0%

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 2, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets December 2, 2021 13:19 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 2, 2021 13:21 Inactive
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the ticket description. Right now it is about The Zendesk Chat connector.

…urochkin/source-pokeapi-refactor-to-use-the-cdk
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Dec 3, 2021

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1535418329
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1535418329
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                             Stmts   Miss  Cover
	 ----------------------------------------------------
	 source_pokeapi/__init__.py           2      2     0%
	 source_pokeapi/pokemon_list.py       2      2     0%
	 source_pokeapi/source.py            30     30     0%
	 ----------------------------------------------------
	 TOTAL                               34     34     0%

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets December 3, 2021 13:32 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 13:34 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Dec 3, 2021

/publish connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1535442631
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/1535442631

@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 13:41 Inactive
@yevhenii-ldv yevhenii-ldv merged commit 5393070 into master Dec 3, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/source-pokeapi-refactor-to-use-the-cdk branch December 3, 2021 13:53
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 3, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets December 3, 2021 13:55 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Pokeapi: refactor to use the CDK
5 participants