Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change COPY to ADD in dockerfiles to reduce java images #8516

Merged

Conversation

haoranyu
Copy link
Contributor

@haoranyu haoranyu commented Dec 5, 2021

What

As described in #7551, we can reduce java image sizes.

How

It can be achieved by using ADD instead of COPY in dockerfiles.

Recommended reading order

  1. airbyte-integrations/bases/*
  2. airbyte-integrations/connector-templates/*
  3. airbyte-integrations/connectors/*

🚨 User Impact 🚨

No.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 5, 2021
@marcosmarxm
Copy link
Member

@haoranyu can you post some images you have built using this new strategy and compare with the older build?

@sherifnada sherifnada requested review from alexandr-shegeda and removed request for sherifnada December 15, 2021 10:15
@sherifnada
Copy link
Contributor

@alexandr-shegeda can someone from the team review?

Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the contribution @haoranyu

@marcosmarxm
Copy link
Member

Because isn't a new feature or something critical for connectors I won't release a new version at the moment.
Thanks for the contribution @haoranyu

@marcosmarxm marcosmarxm merged commit 8ac2c6f into airbytehq:master Dec 17, 2021
@haoranyu
Copy link
Contributor Author

@haoranyu can you post some images you have built using this new strategy and compare with the older build?

I'm sorry that I was busy last week and didn't reply in time.

looks great, thanks for the contribution @haoranyu

I'm glad to help.

@alexandr-shegeda
Copy link
Contributor

We noticed that after changing COPY with ADD in the Dockerfile all integration tests start failing, so we will revert these changes until we find a root cause and fix the tests. Here is the ticket for tracking progress #8996

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…#8516)

Co-authored-by: Oleksandr Sheheda <alexandr-shegeda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community gl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants