Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added benchmarks scripts with small instruction #8529

Merged
merged 24 commits into from Dec 12, 2021
Merged

Added benchmarks scripts with small instruction #8529

merged 24 commits into from Dec 12, 2021

Conversation

andriikorotkov
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

added benchmarks scripts with small instruction

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov
updated source-mongodb-v2 performance
f77238f
@andriikorotkov
updated code style
6ac8c93
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
6e3f202 
…6544-mongo-performance-issues
@andriikorotkov
fixed remarks
9ff2bfd
@andriikorotkov
fixed remarks
4eb9d09
@andriikorotkov
fixed remarks
451fe71
@andriikorotkov
updated strict encrypt source mongodb version
ae3c06e
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
5f19252 
…6544-mongo-performance-issues

� Conflicts:
�	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e.json
�	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
�	airbyte-integrations/connectors/source-mongodb-strict-encrypt/Dockerfile
�	airbyte-integrations/connectors/source-mongodb-v2/Dockerfile
�	docs/integrations/sources/mongodb-v2.md
@andriikorotkov
updated source mongodb work with empty collections
a1d23ff
@andriikorotkov
updated source mongodb timestamp cursor
799c877
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
a5d444c 
…6544-mongo-performance-issues
@andriikorotkov
updated mongodb source perfomance
e83f8d3
@andriikorotkov
fix code style
9a8dce4
@andriikorotkov
fix code style
18fd7b7
@andriikorotkov
updated tests and documentation
70ccff2
@andriikorotkov
updated tests and documentation
868d7e9
@andriikorotkov
updated tests and documentation
a3c6284
@andriikorotkov
added vudangngoc changes
d6399b3
@andriikorotkov
updated code style
d427834
@andriikorotkov
updated code style
7a8c313
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
01c6b4d 
…8048-add-scripts

� Conflicts:
�	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e.json
�	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
�	airbyte-config/init/src/main/resources/seed/source_specs.yaml
�	airbyte-integrations/connectors/source-mongodb-strict-encrypt/Dockerfile
�	airbyte-integrations/connectors/source-mongodb-v2/Dockerfile
�	docs/integrations/sources/mongodb-v2.md
@andriikorotkov
added benchmarks scripts with small instruction
8a4a964
@andriikorotkov andriikorotkov temporarily deployed to more-secrets December 6, 2021 11:17 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 6, 2021
tuliren
tuliren reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I have two suggestions:

  1. The documentation and the script can be moved under each source database module.

    Take MySQL as an example:

    • The documentation can be moved to airbyte-integrations/connectors/source-mysql/README.md.
    • The SQL script can be moved to airbyte-integrations/connectors/source-mysql/src/test-performance/sql/*.sql.

  2. The contents of the screenshots should be replaced with TODOs as comments in the scripts. In this way, it is easier to find which line of code to modify (rather than searching for them based on the screenshots).

docs/benchmarks-scripts/mssql/mssql-script.sql Outdated Show resolved Hide resolved
docs/benchmarks-scripts/mssql/mssql-script.sql Outdated Show resolved Hide resolved
docs/benchmarks-scripts/mssql/mssql-script.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/connectors Connector related issues and removed area/documentation Improvements or additions to documentation labels Dec 9, 2021
@andriikorotkov andriikorotkov temporarily deployed to more-secrets December 9, 2021 18:36 Inactive
@andriikorotkov
Copy link
Contributor Author

@tuliren, I added the changes you mentioned. I propose to merge this pull request after we merge Eugene's pull request.

@tuliren tuliren linked an issue Dec 10, 2021 that may be closed by this pull request
Document how to use SQL scripts to create benchmark databases #8712
Closed
@andriikorotkov andriikorotkov temporarily deployed to more-secrets December 11, 2021 15:33 Inactive
tuliren
tuliren approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tuliren tuliren marked this pull request as ready for review December 12, 2021 18:30
@tuliren tuliren merged commit 7591883 into master Dec 12, 2021
@tuliren tuliren deleted the akorotkov/8048-add-scripts branch December 12, 2021 18:30
@jrhizor jrhizor mentioned this pull request Dec 14, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@andriikorotkov @schlattk
Added benchmarks scripts with small instruction (airbytehq#8529)
2688280 
* updated source-mongodb-v2 performance

* updated code style

* fixed remarks

* fixed remarks

* fixed remarks

* updated strict encrypt source mongodb version

* updated source mongodb work with empty collections

* updated source mongodb timestamp cursor

* updated mongodb source perfomance

* fix code style

* fix code style

* updated tests and documentation

* updated tests and documentation

* updated tests and documentation

* added vudangngoc changes

* updated code style

* updated code style

* added benchmarks scripts with small instruction

* fixed remarks

* updated ci performance test sh script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren approved these changes

@etsybaev etsybaev Awaiting requested review from etsybaev

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

@DoNotPanicUA DoNotPanicUA Awaiting requested review from DoNotPanicUA

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use SQL scripts to create benchmark databases
2 participants
@andriikorotkov @tuliren