Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: posthog, recurly, redshift, salesforce, salesloft #8617

Merged
merged 39 commits into from Jan 25, 2022

Conversation

igrankova
Copy link
Contributor

@igrankova igrankova commented Dec 8, 2021

What

Add title and description properties to each field in source-connectors specifications:
source-posthog
source-recurly
source-redshift
source-salesforce
source-salesloft

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here


This change is Reviewable

@igrankova igrankova temporarily deployed to more-secrets December 8, 2021 10:30 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 8, 2021
@igrankova igrankova temporarily deployed to more-secrets December 8, 2021 10:46 Inactive
@igrankova
Copy link
Contributor Author

igrankova commented Dec 8, 2021

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1554075425
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1554075425
No Python unittests run

@igrankova
Copy link
Contributor Author

igrankova commented Dec 8, 2021

/test connector=connectors/source-posthog

🕑 connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/1554077222
❌ connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/1554077222
🐛 https://gradle.com/s/c2uar2omizf2e

@igrankova
Copy link
Contributor Author

igrankova commented Dec 8, 2021

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1554078519
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/1554078519
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_recharge/__init__.py       2      2     0%
	 source_recharge/api.py           75     75     0%
	 source_recharge/source.py        21     21     0%
	 -------------------------------------------------
	 TOTAL                            98     98     0%

@igrankova
Copy link
Contributor Author

igrankova commented Dec 8, 2021

/test connector=connectors/source-recurly

🕑 connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/1554079724
✅ connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/1554079724
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%

@igrankova
Copy link
Contributor Author

igrankova commented Dec 8, 2021

/test connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1554080756
✅ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1554080756
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:49 Inactive
@igrankova
Copy link
Contributor Author

/test connector=connectors/source-salesforce

@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:50 Inactive
@igrankova
Copy link
Contributor Author

/test connector=connectors/source-salesloft

@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:51 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:51 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 8, 2021 12:52 Inactive
@igrankova igrankova changed the title Update fields in source-connectors specifications: postgres, posthog, recharge, recurly, redshift, salesforce, salesloft Update fields in source-connectors specifications: postgres, posthog, recharge, recurly, redshift, salesforce, salesloft, source-file-secure Dec 10, 2021
@igrankova igrankova temporarily deployed to more-secrets December 13, 2021 13:48 Inactive
@grubberr grubberr temporarily deployed to more-secrets December 14, 2021 15:54 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-recurly

🕑 connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/1745202660
✅ connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/1745202660

@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1745203496
✅ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1745203496

@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1745204620
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1745204620

@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745205475
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745205475

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:46 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:46 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:46 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:46 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:46 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745247272
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745247272

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 11:58 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745299752
✅ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/1745299752

@grubberr grubberr temporarily deployed to more-secrets January 25, 2022 12:10 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 12:11 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1745345252
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1745345252

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 12:21 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 25, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1745421943
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1745421943
🐛 https://gradle.com/s/4jpbdzyypalq4

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 25, 2022 12:39 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 25, 2022 14:08 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 25, 2022 14:10 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 25, 2022 14:12 Inactive
@grubberr grubberr changed the title Update fields in source-connectors specifications: postgres, posthog, recurly, redshift, salesforce, salesloft Update fields in source-connectors specifications: posthog, recurly, redshift, salesforce, salesloft Jan 25, 2022
@grubberr grubberr merged commit 579923d into master Jan 25, 2022
@grubberr grubberr deleted the igrankova/issue-8369-update-title-description branch January 25, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
Archived in project
4 participants