🎉 New source: Qualaroo #8623

danieldiamond · 2021-12-08T12:59:43Z

What

Adding a new source: Qualaroo

How

See PR

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

harshithmullapudi · 2021-12-08T15:17:16Z

@danieldiamond thanks for the contribution. We will review this soon.

danieldiamond · 2021-12-08T21:56:33Z

 python -m pytest unit_tests
Test session starts (platform: darwin, Python 3.9.9, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/danieldiamond/repos/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, requests-mock-1.9.3, mock-3.6.1, timeout-1.4.2
collecting ...
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_request_params ✓              25% ██▌
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_next_page_token ✓             50% █████
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_surveys_stream ✓              75% ███████▌
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_responses_stream ✓           100% ██████████
====================================================== warnings summary ======================================================
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
  /Users/danieldiamond/.virtualenvs/qualaroo/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:38: DeprecationWarning: Call to deprecated class NoAuth. (Set `authenticator=None` instead) -- Deprecated since version 0.1.20.
    self._authenticator = NoAuth()

airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
  /Users/danieldiamond/.virtualenvs/qualaroo/lib/python3.9/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.20s):
       4 passed

airbyte-integrations/connectors/source-qualaroo/source_qualaroo/schemas/responses.json

marcosmarxm · 2021-12-09T17:06:17Z

@danieldiamond can you post the integratoin test results too?

danieldiamond · 2021-12-10T01:10:23Z

➜ python -m pytest unit_tests
Test session starts (platform: darwin, Python 3.9.9, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/danieldiamond/repos/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, requests-mock-1.9.3, mock-3.6.1, timeout-1.4.2
collecting ...
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_request_params ✓                       25% ██▌
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_next_page_token ✓                      50% █████
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_surveys_stream ✓                       75% ███████▌
 airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py::test_responses_stream ✓                    100% ██████████
========================================================== warnings summary ===========================================================
airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
  /Users/danieldiamond/.virtualenvs/qualaroo/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:38: DeprecationWarning: Call to deprecated class NoAuth. (Set `authenticator=None` instead) -- Deprecated since version 0.1.20.
    self._authenticator = NoAuth()

airbyte-integrations/connectors/source-qualaroo/unit_tests/test_streams.py: 11 warnings
  /Users/danieldiamond/.virtualenvs/qualaroo/lib/python3.9/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.39s):
       4 passed

marcosmarxm · 2021-12-11T00:33:53Z

@danieldiamond can you run ./gradlew airbyte-integrations:connectors:source-qualaroo:integrationTest?

danieldiamond · 2021-12-11T12:41:20Z

@marcosmarxm misread your previous comment. here's the integration tests:

> Task :airbyte-integrations:connectors:source-qualaroo:sourceAcceptanceTest
============================= test session starts ==============================
platform linux -- Python 3.7.11, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /test_input
plugins: sugar-0.9.4, timeout-1.4.2
collected 13 items / 1 skipped / 12 selected

test_core.py ............                                                [ 92%]
test_full_refresh.py .                                                   [100%]

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 13 passed, 1 skipped in 21.76s ========================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD SUCCESSFUL in 47s
81 actionable tasks: 44 executed, 37 up-to-date

danieldiamond · 2021-12-14T10:01:50Z

@marcosmarxm do you need anything else on my end to progress this?

harshithmullapudi · 2021-12-14T10:03:09Z

@marcosmarxm can I take this up?

marcosmarxm · 2021-12-15T00:01:57Z

I requested the credentials in #8800. @danieldiamond do you have tests credentials to share to apply in tests?

danieldiamond · 2021-12-15T00:04:36Z

@marcosmarxm unfortunately i dont have test credentials

harshithmullapudi

I think we can delete bin folder

airbyte-integrations/connectors/source-qualaroo/bin/.dockerignore

airbyte-integrations/connectors/source-qualaroo/bin/Dockerfile

airbyte-integrations/connectors/source-qualaroo/bin/README.md

danieldiamond · 2022-05-19T21:45:09Z

@harshithmullapudi have you received your credentials for the test qualaroo account?

marcosmarxm · 2022-05-20T13:36:30Z

@harshithmullapudi have you received your credentials for the test qualaroo account?

yes.

init

0b7edb8

github-actions bot added the area/connectors Connector related issues label Dec 8, 2021

octavia-squidington-iii added the community label Dec 8, 2021

alafanechere changed the title ~~🎉 Add Qualaroo Source~~ 🎉 New source: Qualaroo Dec 8, 2021

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 8, 2021

danieldiamond commented Dec 8, 2021

View reviewed changes

airbyte-integrations/connectors/source-qualaroo/source_qualaroo/schemas/responses.json Outdated Show resolved Hide resolved

Add additional docs per connector checklist

c37bd63

danieldiamond force-pushed the danieldiamond/add-qualaroo branch from 1c15921 to c37bd63 Compare December 8, 2021 22:27

De-nest answered_questions

554bbbd

gradlew format

265329e

fix integration tests and remove incremental stream

2e47a9e

marcosmarxm assigned harshithmullapudi Dec 14, 2021

marcosmarxm mentioned this pull request Dec 15, 2021

CI Sandbox account for Qualaroo #8800

Closed

harshithmullapudi suggested changes Dec 16, 2021

View reviewed changes

Remove bin files

1d7287c

danieldiamond requested a review from harshithmullapudi December 19, 2021 04:40

harshithmullapudi mentioned this pull request Dec 21, 2021

Publish new source: Qualaroo #8983

Merged

harshithmullapudi merged commit 105bb58 into airbytehq:master Dec 21, 2021

jrhizor mentioned this pull request Dec 22, 2021

Bump Airbyte version from 0.34.4-alpha to 0.35.0-alpha #9023

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New source: Qualaroo #8623

🎉 New source: Qualaroo #8623

danieldiamond commented Dec 8, 2021 •

edited

Loading

harshithmullapudi commented Dec 8, 2021

danieldiamond commented Dec 8, 2021

marcosmarxm commented Dec 9, 2021

danieldiamond commented Dec 10, 2021

marcosmarxm commented Dec 11, 2021

danieldiamond commented Dec 11, 2021

danieldiamond commented Dec 14, 2021

harshithmullapudi commented Dec 14, 2021

marcosmarxm commented Dec 15, 2021

danieldiamond commented Dec 15, 2021 •

edited

Loading

harshithmullapudi left a comment •

edited

Loading

danieldiamond commented May 19, 2022

marcosmarxm commented May 20, 2022

🎉 New source: Qualaroo #8623

🎉 New source: Qualaroo #8623

Conversation

danieldiamond commented Dec 8, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

harshithmullapudi commented Dec 8, 2021

danieldiamond commented Dec 8, 2021

marcosmarxm commented Dec 9, 2021

danieldiamond commented Dec 10, 2021

marcosmarxm commented Dec 11, 2021

danieldiamond commented Dec 11, 2021

danieldiamond commented Dec 14, 2021

harshithmullapudi commented Dec 14, 2021

marcosmarxm commented Dec 15, 2021

danieldiamond commented Dec 15, 2021 • edited Loading

harshithmullapudi left a comment • edited Loading

Choose a reason for hiding this comment

danieldiamond commented May 19, 2022

marcosmarxm commented May 20, 2022

danieldiamond commented Dec 8, 2021 •

edited

Loading

danieldiamond commented Dec 15, 2021 •

edited

Loading

harshithmullapudi left a comment •

edited

Loading