🐛Source Google Analytics v4: fix date format #8656

annalvova05 · 2021-12-09T10:01:24Z

What

Google Analytics v4 doesn't convert date-format data to date-type in the Postgresql destination.

How

Add format to date column (ga_date). It converts date-format data to date type in a destination.
Parse response with date.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

annalvova05 · 2021-12-09T10:16:38Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1558224135
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1558224135
🐛 https://gradle.com/s/7vwmnzh25o2n6

…x-datetime

…x-datetime # Conflicts: # docs/integrations/sources/google-analytics-v4.md

annalvova05 · 2021-12-14T12:35:00Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1577836506
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1577836506
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
=================== 15 passed, 1 skipped in 63.68s (0:01:03) ===================

antixar

Please add an integration test for checking of expected records.

annalvova05 · 2021-12-15T10:24:26Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1582247582
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1582247582
🐛

…x-datetime

annalvova05 · 2021-12-15T11:06:01Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1582399949
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1582399949
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
=================== 15 passed, 1 skipped in 63.89s (0:01:03) ===================

…x-datetime # Conflicts: # tools/bin/ci_credentials.sh

annalvova05 · 2021-12-15T15:07:37Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583327089
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583327089
🐛 https://gradle.com/s/2e6qqd762xqrs

annalvova05 · 2021-12-15T15:43:43Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583474134
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583474134
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       101     65    36%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  965    458    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
=================== 15 passed, 1 skipped in 68.55s (0:01:08) ===================

antixar

lgtm
Please publish your changes

annalvova05 · 2021-12-15T17:40:10Z

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583930119
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1583930119

* add data format to json schemas * add window_in_days in check * bump version * upd doc * typo * parse date in response * upd * bump version * add expected_records * remove github creds * merge * bump version

annalvova05 added 3 commits December 8, 2021 12:33

add data format to json schemas

0ff1f5d

add window_in_days in check

0e772a7

bump version

eb26ea7

annalvova05 requested review from midavadim and lazebnyi December 9, 2021 10:01

github-actions bot added the area/connectors Connector related issues label Dec 9, 2021

upd doc

30b2dc4

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 9, 2021

annalvova05 linked an issue Dec 9, 2021 that may be closed by this pull request

Google Analytics Date Time Issue #6887

Closed

annalvova05 self-assigned this Dec 9, 2021

annalvova05 temporarily deployed to more-secrets December 9, 2021 10:09 Inactive

jrhizor temporarily deployed to more-secrets December 9, 2021 10:18 Inactive

annalvova05 marked this pull request as draft December 9, 2021 10:35

annalvova05 removed request for midavadim and lazebnyi December 9, 2021 10:35

annalvova05 added 2 commits December 9, 2021 17:56

Merge remote-tracking branch 'origin/master' into alvova/6887-gav4-fi…

b8c17b2

…x-datetime

typo

e020d1e

annalvova05 temporarily deployed to more-secrets December 9, 2021 17:09 Inactive

annalvova05 added 3 commits December 14, 2021 12:40

Merge remote-tracking branch 'origin/master' into alvova/6887-gav4-fi…

79261ae

…x-datetime # Conflicts: # docs/integrations/sources/google-analytics-v4.md

parse date in response

47a57e1

upd

4ee105e

annalvova05 temporarily deployed to more-secrets December 14, 2021 12:35 Inactive

jrhizor temporarily deployed to more-secrets December 14, 2021 12:37 Inactive

bump version

f7703c4

annalvova05 requested review from bazarnov and antixar December 14, 2021 13:34

annalvova05 marked this pull request as ready for review December 14, 2021 13:35

annalvova05 temporarily deployed to more-secrets December 14, 2021 13:35 Inactive

bazarnov approved these changes Dec 14, 2021

View reviewed changes

antixar suggested changes Dec 14, 2021

View reviewed changes

add expected_records

6e78328

annalvova05 temporarily deployed to more-secrets December 15, 2021 10:25 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 10:26 Inactive

annalvova05 added 2 commits December 15, 2021 12:42

Merge remote-tracking branch 'origin/master' into alvova/6887-gav4-fi…

727c6a0

…x-datetime

remove github creds

cdb4acc

annalvova05 temporarily deployed to more-secrets December 15, 2021 11:07 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 11:07 Inactive

annalvova05 requested a review from antixar December 15, 2021 11:13

annalvova05 added 2 commits December 15, 2021 17:02

Merge remote-tracking branch 'origin/master' into alvova/6887-gav4-fi…

dd2c9e3

…x-datetime # Conflicts: # tools/bin/ci_credentials.sh

merge

3c0f321

annalvova05 temporarily deployed to more-secrets December 15, 2021 15:08 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 15:09 Inactive

jrhizor temporarily deployed to more-secrets December 15, 2021 15:45 Inactive

antixar approved these changes Dec 15, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets December 15, 2021 17:42 Inactive

bump version

2d758bb

annalvova05 merged commit e6fac63 into master Dec 15, 2021

annalvova05 deleted the alvova/6887-gav4-fix-datetime branch December 15, 2021 19:25

annalvova05 temporarily deployed to more-secrets December 15, 2021 19:26 Inactive

jrhizor mentioned this pull request Dec 16, 2021

Bump Airbyte version from 0.33.12-alpha to 0.34.0-alpha #8834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Google Analytics v4: fix date format #8656

🐛Source Google Analytics v4: fix date format #8656

annalvova05 commented Dec 9, 2021 •

edited

Loading

annalvova05 commented Dec 9, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 14, 2021 •

edited by github-actions bot

Loading

antixar left a comment

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

antixar left a comment

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

🐛Source Google Analytics v4: fix date format #8656

🐛Source Google Analytics v4: fix date format #8656

Conversation

annalvova05 commented Dec 9, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

annalvova05 commented Dec 9, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 14, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

annalvova05 commented Dec 15, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 15, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 15, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 15, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

annalvova05 commented Dec 15, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 9, 2021 •

edited

Loading

annalvova05 commented Dec 9, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 14, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 15, 2021 •

edited by github-actions bot

Loading