Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarQube QA GitHub jobs #8668

Merged
merged 11 commits into from
Dec 30, 2021
Merged

SonarQube QA GitHub jobs #8668

merged 11 commits into from
Dec 30, 2021

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Dec 9, 2021

What

Playground for #7881

How

Work on generating the jobs reports and put it into SonarQube QA.

@htrueman htrueman linked an issue Dec 9, 2021 that may be closed by this pull request
Integrate airbyte repo with SonarQube #7881
Closed
6 tasks
@htrueman htrueman changed the title Htrueman/sonarqube qa GitHub jobs SonarQube QA GitHub jobs Dec 9, 2021
@htrueman htrueman temporarily deployed to more-secrets December 9, 2021 15:25 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 9, 2021 15:26 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 9, 2021 15:34 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 9, 2021 15:35 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 10, 2021 11:20 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 10, 2021 11:21 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 10, 2021 13:43 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 10, 2021 13:44 Inactive
@htrueman
Copy link
Contributor Author

There is a doc topic on building the analytics based on test reports https://docs.sonarqube.org/latest/analysis/coverage/
SonarQube supports a lot of default formats as well as we may use the common formats (also described in docs above).

So the goal for now is to generate reports into the temp dir and pass it to SonarQube. It should be really easy for python test formats. But may be a bit challenging if the default formatting is not supported or report format is not supported.

@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:19 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:20 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:36 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:37 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:45 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:46 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:47 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:48 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:54 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 18:55 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:27 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:29 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:34 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:36 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:48 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 19:49 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 20:00 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 20:02 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 22, 2021 20:02 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 28, 2021 19:18 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 28, 2021 19:21 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 28, 2021 19:37 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 28, 2021 19:44 Inactive
@htrueman htrueman requested a review from avida December 29, 2021 07:30
@htrueman
Fix action.
aaf49a5 
Update unit tests.
Code cleanup and fixes.
@htrueman htrueman force-pushed the htrueman/sonarqube-qa-github-jobs branch from 367772d to aaf49a5 Compare December 29, 2021 08:44
@htrueman htrueman temporarily deployed to more-secrets December 29, 2021 08:46 Inactive
avida
avida approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except https://github.com/airbytehq/airbyte/pull/8668/files#r776218491 comment. Please confirm this is not a typo before merging

antixar
antixar suggested changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main goals were implemented correctly. But there are several minor questions and comments.
At first we need to finish the "detection" logic. The SonarQube service can work and without reports.

What is a goal of the file airbyte-integrations/connectors/tasks.py ?
Can we move it to the "tools" folder?

.github/workflows/detect-changed-modules-and-build-reports.yml Outdated Show resolved Hide resolved
.github/workflows/detect-changed-modules-and-build-reports.yml Outdated Show resolved Hide resolved
tools/ci_static_check_reports/build_static_checkers_reports.py Outdated Show resolved Hide resolved
tools/ci_static_check_reports/build_static_checkers_reports.py Outdated Show resolved Hide resolved
tools/ci_static_check_reports/detect_changed_modules.py Outdated Show resolved Hide resolved
tools/ci_static_check_reports/build_static_checkers_reports.py Outdated Show resolved Hide resolved
tools/ci_static_check_reports/build_static_checkers_reports.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/tasks.py Show resolved Hide resolved
tools/ci_static_check_reports/unit_tests/test_build_static_checkers_reports.py Outdated Show resolved Hide resolved
tools/ci_static_check_reports/build_static_checkers_reports.py Outdated Show resolved Hide resolved
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 15:35 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 15:45 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 15:53 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 16:00 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 16:29 Inactive
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 16:33 Inactive
@htrueman
Update unit tests.
1fb5be2 
Add changed module filter.
@htrueman htrueman temporarily deployed to more-secrets December 30, 2021 17:37 Inactive
@htrueman htrueman merged commit ff45a31 into master Dec 30, 2021
@htrueman htrueman deleted the htrueman/sonarqube-qa-github-jobs branch December 30, 2021 17:37
@jrhizor jrhizor mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avida avida avida approved these changes

@sergei-solonitcyn sergei-solonitcyn Awaiting requested review from sergei-solonitcyn

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@Zirochkaa Zirochkaa Awaiting requested review from Zirochkaa

@antixar antixar Awaiting requested review from antixar

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate airbyte repo with SonarQube
3 participants
@htrueman @avida @antixar