Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Analytics V4: Fix window in days validation issue #8676

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Dec 9, 2021

What

#8655 - KeyError('window_in_days') in Google Analytics Source Connector

Setting default value for window_in_days was emplimented in stream method, but in check_connection method was TestStreamConnection but it inherit from GoogleAnalyticsV4Stream which during initialization try get value from config dict by window_in_days key before validation in stream method of SourceGoogleAnalyticsV4 class.

How

Shifted window_in_days validation from stream method to __init__ method of GoogleAnalyticsV4Stream class.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 9, 2021
@lazebnyi lazebnyi linked an issue Dec 9, 2021 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1559848932
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1559848932
🐛 https://gradle.com/s/wakjuzzyxdgbq

@jrhizor jrhizor temporarily deployed to more-secrets December 9, 2021 17:14 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1559919763
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1559919763
🐛 https://gradle.com/s/yli2dealwqnua

@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2021 17:31 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 9, 2021 17:32 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2021

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1560120731
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1560120731
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              235     95    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  946    442    53%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       246     65    74%
	 ------------------------------------------------------------
	 TOTAL                                      248     65    74%

@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2021 18:24 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 9, 2021 18:25 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2021

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1560149882
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1560149882

@jrhizor jrhizor temporarily deployed to more-secrets December 9, 2021 18:34 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2021 18:44 Inactive
@lazebnyi lazebnyi merged commit 0bf8f77 into master Dec 9, 2021
@lazebnyi lazebnyi deleted the lazebnyi/8655-fix-google-analytics-v4-window-in-days-validation-issue branch December 9, 2021 18:48
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2021 18:49 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…rbytehq#8676)

* Fix window in days validation issue

* Fix urllib.parse.urljoin path parsing bug

* Updated catalog to new service test creds

* Updated PR number and bumped version in spec yaml and seed

* Fix documentation URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError('window_in_days') in Google Analytics Source Connector
4 participants