-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Updated ci performance test sh script #8772
Merged
andriikorotkov
merged 19 commits into
master
from
akorotkov/change-sh-for-cpu-and-memory
Dec 14, 2021
Merged
🎉 Updated ci performance test sh script #8772
andriikorotkov
merged 19 commits into
master
from
akorotkov/change-sh-for-cpu-and-memory
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change-sh-for-cpu-and-memory
…change-sh-for-cpu-and-memory
…change-sh-for-cpu-and-memory � Conflicts: � .github/workflows/test-performance-command.yml
…change-sh-for-cpu-and-memory
…change-sh-for-cpu-and-memory
…change-sh-for-cpu-and-memory
…change-sh-for-cpu-and-memory
etsybaev
approved these changes
Dec 14, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* updated ci performance test sh script * updated ci performance test sh script * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg * set all params to one arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added changes to ci_performance_test.sh script that can run performance tests with CPU and memory limits.
How
Added processing of the second and third parameters to use them to transfer CPU and memory limits. Each of these new parameters is optional.
Recommended reading order
x.sh
y.yaml
🚨 User Impact 🚨
No impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes