Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Testing destination: multiple logging modes #8824

Merged
merged 18 commits into from
Dec 19, 2021
Merged

🎉 Testing destination: multiple logging modes #8824

merged 18 commits into from
Dec 19, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Dec 16, 2021 •
edited
Loading

What

  • E2E Test Destination
    • Add multiple logging modes.
    • Make the silent mode truly silent.
    • It will be added to OSS.
  • Dev Null Destination
    • This destination inherits from the E2E Test Destination, and only allows the silent mode.
    • It will be added to Airbyte Cloud.

🚨 User Impact 🚨

  • Current users should re-create the destination after upgrading to 0.2.0.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 16, 2021
@tuliren tuliren temporarily deployed to more-secrets December 16, 2021 00:40 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 16, 2021 05:19 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 01:51 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 06:50 Inactive
@tuliren tuliren changed the title Patch testing destination 🎉 Testing destination: multiple logging modes Dec 17, 2021
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 07:22 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 07:25 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 07:36 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 07:38 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Dec 17, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1591173877
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1591173877
No Python unittests run

@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 07:42 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 17, 2021 09:03 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 18, 2021 22:21 Inactive
@tuliren tuliren marked this pull request as ready for review December 18, 2021 23:47
@tuliren
Copy link
Contributor Author

tuliren commented Dec 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1597165823
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1597165823
No Python unittests run

@tuliren
Copy link
Contributor Author

tuliren commented Dec 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-dev-null

🕑 connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1597165882
✅ connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1597165882
No Python unittests run

@tuliren tuliren temporarily deployed to more-secrets December 18, 2021 23:48 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 18, 2021 23:50 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 19, 2021 00:08 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 19, 2021 00:16 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 19, 2021 04:33 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 19, 2021 07:44 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Dec 19, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1598011902
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1598011902

@tuliren
Copy link
Contributor Author

tuliren commented Dec 19, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-dev-null

🕑 connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1598011976
✅ connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1598011976

@jrhizor jrhizor temporarily deployed to more-secrets December 19, 2021 07:57 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 19, 2021 07:57 Inactive
@tuliren tuliren temporarily deployed to more-secrets December 19, 2021 08:18 Inactive
@tuliren tuliren merged commit 0de30f5 into master Dec 19, 2021
@tuliren tuliren deleted the liren/logging-destination branch December 19, 2021 08:33
This was referenced Dec 19, 2021
Merged
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@tuliren @schlattk
🎉 Testing destination: multiple logging modes (airbytehq#8824)
e5e3ed4 
* Implement destination null

* Update existing testing destinations

* Merge in logging consumer

* Remove old destination null

* Add documentation

* Add destination to build and summary

* Fix test

* Update acceptance test

* Log state message

* Remove unused variable

* Remove extra statement

* Remove old null doc

* Add dev null destination

* Update doc to include changelog for dev null

* Format code

* Fix doc

* Register e2e test destination in seed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens Awaiting requested review from cgardens

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/e2e-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuliren @jrhizor @karinakuz