Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Fecebook-Marketing: add asset_feed_spec to ad creatives stream #8962

Merged
merged 8 commits into from
Dec 21, 2021

Conversation

bazarnov
Copy link
Collaborator

What

Resolving #7576

How

  • added the property of asset_feed_spec to ad creatives stream schema.

🚨 User Impact 🚨

User would need to Update connector's schema in order to apply these changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Dec 20, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 20, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 20, 2021
@bazarnov bazarnov temporarily deployed to more-secrets December 20, 2021 12:50 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 20, 2021

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1602308372
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1602308372
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       105     45    57%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  976    439    55%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     17    77%
	 source_facebook_marketing/async_job.py      92     58    37%
	 source_facebook_marketing/common.py         37     11    70%
	 source_facebook_marketing/source.py        114     66    42%
	 source_facebook_marketing/streams.py       253     90    64%
	 ------------------------------------------------------------
	 TOTAL                                      573    242    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_facebook_marketing/__init__.py        2      0   100%
	 source_facebook_marketing/api.py            75     18    76%
	 source_facebook_marketing/async_job.py      92      1    99%
	 source_facebook_marketing/common.py         37      1    97%
	 source_facebook_marketing/source.py        114     73    36%
	 source_facebook_marketing/streams.py       253     89    65%
	 ------------------------------------------------------------
	 TOTAL                                      573    182    68%

@bazarnov bazarnov temporarily deployed to more-secrets December 20, 2021 13:47 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 13:48 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please publish your changes

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 21, 2021

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1606364763
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1606364763

@bazarnov bazarnov temporarily deployed to more-secrets December 21, 2021 10:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 21, 2021 10:41 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 21, 2021 10:56 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 21, 2021 11:13 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 21, 2021 11:23 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 21, 2021 13:18 Inactive
@bazarnov bazarnov merged commit 1029945 into master Dec 21, 2021
@bazarnov bazarnov deleted the bazarnov/7576-db-marketing-asset-feed-spec branch December 21, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: Add field asset_feed_spec to Ad Creative stream
5 participants