Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Destination Snowflake SQL compilation error #9006

Merged
merged 12 commits into from Dec 21, 2021
Merged

🐛 Destination Snowflake SQL compilation error #9006

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
93d53ac
fix for jdk 17
Dec 15, 2021
ede8d38
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 15, 2021
27be3fe
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 15, 2021
ca75033
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
72ab46f
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
aec3384
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 16, 2021
7efd5aa
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 20, 2021
6a773f9
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 21, 2021
fa18537
Merge branch 'master' of github.com:airbytehq/airbyte
Dec 21, 2021
8b92a8d
updated SnowflakeDatabase jdbc connection params
Dec 21, 2021
dbb2d95
updated spec.json
Dec 21, 2021
6378294
updated spec.json
Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...wflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ public class SnowflakeDatabase {

private static final Duration NETWORK_TIMEOUT = Duration.ofMinutes(1);
private static final Duration QUERY_TIMEOUT = Duration.ofHours(3);

private static final SnowflakeSQLNameTransformer nameTransformer = new SnowflakeSQLNameTransformer();
public static Connection getConnection(final JsonNode config) throws SQLException {
final String connectUrl = String.format("jdbc:snowflake://%s", config.get("host").asText());

Expand All @@ -32,7 +32,7 @@ public static Connection getConnection(final JsonNode config) throws SQLExceptio
properties.put("warehouse", config.get("warehouse").asText());
properties.put("database", config.get("database").asText());
properties.put("role", config.get("role").asText());
properties.put("schema", config.get("schema").asText());
properties.put("schema", nameTransformer.getIdentifier(config.get("schema").asText()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgao this is a good candidate for the testing ticket


properties.put("networkTimeout", Math.toIntExact(NETWORK_TIMEOUT.toSeconds()));
properties.put("queryTimeout", Math.toIntExact(QUERY_TIMEOUT.toSeconds()));
Expand Down