Bmoric/migrate existing schedule #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
benmoriceau
force-pushed
the
bmoric/migrate-existing-schedule
branch
from
a22b4c8
to
0851a27
Compare
…rate-existing-schedule
benmoriceau
requested review from
jrhizor,
cgardens and
davinchia
and removed request for
jrhizor and
cgardens
davinchia
reviewed
Dec 24, 2021
| @@ -188,6 +197,16 @@ public static ServerRunnable getServer(final ServerFactory apiFactory, final Con | |||
| configs.getWorkspaceRoot(), | |||
| configs.getAirbyteVersionOrWarning(), | |||
| featureFlags); | |||
| final JobNotifier jobNotifier = new JobNotifier( | |||
There was a problem hiding this comment.
we can shift this down to only be created inside the featureFlags.usesNewScheduler block.
…rate-existing-schedule
jrhizor
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is migrating existing connection to the new scheduler. It refrain from migrating a connection that have already be migrated.
closes #8546