Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: google-ads #9149

Merged
merged 11 commits into from
Jan 19, 2022

Conversation

ycherniaiev
Copy link
Contributor

@ycherniaiev ycherniaiev commented Dec 28, 2021

What

Add title and description properties to each field in source-connectors specifications:
source-google-ads

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here


This change is Reviewable

@ycherniaiev ycherniaiev added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 28, 2021
@ycherniaiev ycherniaiev self-assigned this Dec 28, 2021
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 28, 2021
@ycherniaiev ycherniaiev linked an issue Dec 28, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 28, 2021 12:04 Inactive
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Dec 28, 2021

/test connector=connectors/source-google-ads

πŸ•‘ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1630943635
βœ… connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1630943635
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75     50    33%
	 source_google_ads/google_ads.py               67     10    85%
	 source_google_ads/custom_query_stream.py      75     50    33%/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/.venv/lib/python3.8/site-packages/coverage/report.py:87: CoverageWarning: Couldn't parse '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-31>': No source for code: '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-31>'. (couldnt-parse)
	 source_google_ads/source.py                   64     23    64%
	 source_google_ads/streams.py                  86      4    95%
	   coverage._warn(msg, slug="couldnt-parse")
	 --------------------------------------------------------------
	 TOTAL                                        294     87    70%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 --------------------------------------------------------------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/.venv/lib/python3.8/site-packages/coverage/report.py:87: CoverageWarning: Couldn't parse '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-31>': No source for code: '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-31>'. (couldnt-parse)
	 source_google_ads/custom_query_stream.py      75      6    92%
	 source_google_ads/google_ads.py               67      6    91%
	 source_google_ads/source.py                   64     17    73%
	   coverage._warn(msg, slug="couldnt-parse")
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/.venv/lib/python3.8/site-packages/coverage/report.py:87: CoverageWarning: Couldn't parse '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-32>': No source for code: '/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-ads/rep-32>'. (couldnt-parse)
	   coverage._warn(msg, slug="couldnt-parse")
	 source_google_ads/streams.py                  86      9    90%
	 --------------------------------------------------------------
	 TOTAL                                        294     38    87%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 15 passed, 1 skipped in 494.98s (0:08:14) ===================

@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 15:16 Inactive
@grubberr
Copy link
Contributor

/test connector=connectors/source-google-ads

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 15, 2022 11:26 Inactive
@grubberr
Copy link
Contributor

grubberr commented Jan 18, 2022

/test connector=connectors/source-google-ads

πŸ•‘ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1712704947
βœ… connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1712704947
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75     50    33%
	 source_google_ads/google_ads.py               67     10    85%
	 source_google_ads/source.py                   64     23    64%
	 source_google_ads/streams.py                  86      4    95%
	 --------------------------------------------------------------
	 TOTAL                                        294     87    70%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75      6    92%
	 source_google_ads/google_ads.py               67      6    91%
	 source_google_ads/source.py                   64     17    73%
	 source_google_ads/streams.py                  86      9    90%
	 --------------------------------------------------------------
	 TOTAL                                        294     38    87%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 15 passed, 1 skipped in 558.16s (0:09:18) ===================

@grubberr grubberr temporarily deployed to more-secrets January 18, 2022 12:31 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 12:32 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 18, 2022 13:18 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 18, 2022 13:20 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 18, 2022 13:25 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor

grubberr commented Jan 19, 2022

/publish connector=connectors/source-google-ads

πŸ•‘ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1717539020
βœ… connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1717539020

@grubberr grubberr temporarily deployed to more-secrets January 19, 2022 10:44 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 10:46 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr merged commit a1e2b63 into master Jan 19, 2022
@grubberr grubberr deleted the ycherniaiev/issue-8926-update-titles-description branch January 19, 2022 11:16
@grubberr grubberr temporarily deployed to more-secrets January 19, 2022 11:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: google-ads
5 participants