Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields in source-connectors specifications: mssql, mssql-strict-encrypt #9206

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Update fields in source-connectors specifications: mssql, mssql-strict-encrypt #9206

merged 6 commits into from
Jan 5, 2022

Conversation

igrankova
Copy link
Contributor

What

Add title and description properties to each field in source-connectors specifications:
source-mssql
source-mssql-strict-encrypt

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova self-assigned this Dec 30, 2021
@igrankova igrankova temporarily deployed to more-secrets December 30, 2021 09:28 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 30, 2021
@igrankova igrankova linked an issue Dec 30, 2021 that may be closed by this pull request
Update fields in source-connectors specifications: mssql, mssql-strict-encrypt #9199
Closed
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 30, 2021
@igrankova
Copy link
Contributor Author

igrankova commented Dec 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1637000571
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1637000571
No Python unittests run

@igrankova igrankova temporarily deployed to more-secrets December 30, 2021 09:33 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 09:34 Inactive
@bazarnov bazarnov self-requested a review January 5, 2022 11:47
@bazarnov bazarnov self-assigned this Jan 5, 2022
@bazarnov
Copy link
Collaborator

bazarnov commented Jan 5, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1658206406
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1658206406

@bazarnov bazarnov temporarily deployed to more-secrets January 5, 2022 11:56 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 5, 2022 11:56 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Jan 5, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1658450549
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1658450549

@jrhizor jrhizor temporarily deployed to more-secrets January 5, 2022 13:07 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 5, 2022 13:19 Inactive
@bazarnov bazarnov merged commit 74cb28e into master Jan 5, 2022
@bazarnov bazarnov deleted the igrankova/issue-9199-update-title-description branch January 5, 2022 13:47
@jrhizor jrhizor mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

Assignees

@bazarnov bazarnov

@igrankova igrankova

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: mssql, mssql-strict-encrypt
3 participants
@igrankova @bazarnov @jrhizor