Normalization fix Snowflake Prefix Tables starting with number #9301

marcosmarxm · 2022-01-05T03:12:09Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…st-pr-9029

…umber

marcosmarxm · 2022-01-05T03:15:22Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1656639500
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1656639500
🐛

marcosmarxm · 2022-01-05T03:42:26Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1656703503
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1656703503
🐛

...te-integrations/bases/base-normalization/normalization/transform_catalog/stream_processor.py

marcosmarxm · 2022-01-05T18:05:13Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1659691962
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1659691962
🐛

ChristopheDuong · 2022-01-05T18:09:50Z

...ion/integration_tests/normalization_test_output/postgres/test_simple_streams/dbt_project.yml

@@ -15,7 +15,7 @@ profile: 'normalize'
 # These configurations specify where dbt should look for different types of files.
 # The `source-paths` config, for example, states that source models can be found
 # in the "models/" directory. You probably won't need to change these!
-source-paths: ["modified_models"]
+source-paths: ["models"]


do you know why these are changing?

No, I didn't change it directly!

marcosmarxm · 2022-01-06T16:12:38Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1663815365
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1663815365
🐛

marcosmarxm · 2022-01-06T20:44:53Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1664814706
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1664814706
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            89     64    28%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/cdk/utils/event_timing.py         47      3    94%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     15    55%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        713    397    44%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     12    92%
	 normalization/transform_catalog/destination_name_transformer.py     155      4    97%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520     39    92%
	 normalization/transform_catalog/table_name_registry.py              174     51    71%
	 normalization/transform_catalog/transform.py                         45     30    33%
	 normalization/transform_catalog/utils.py                             33      0   100%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     46    69%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    188    85%

…umber

marcosmarxm · 2022-01-06T22:30:40Z

/publish connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1665169185
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1665169185

jzcruiser and others added 14 commits December 22, 2021 10:19

add normalization-clickhouse docker build step

c6ae621

Merge branch 'patch-4' of github.com:jzcruiser/airbyte into marcos/te…

b88225e

…st-pr-9029

bump normalization version

cc499c2

small changes gradle

a2517a3

Merge branch 'master' into marcos/test-pr-9029

4a51799

fix settings gradle

a57495c

fix eof file

c56ef54

correct clickhouse normalization

f8ccfd6

Merge branch 'master' into marcos/test-pr-9029

f24ea4b

Refactor jinja template for scd (#9278)

a6e4c31

merge chris code and regenerate sql files

4f9f8ae

correct scd post-hook generation for snowflake

62e7dab

Merge branch 'master' into marcos/normalization-snowflake-startwith-n…

b069b03

…umber

fix scd table for snowflake prefix table with number

6a5f941

marcosmarxm requested review from edgao and ChristopheDuong January 5, 2022 03:12

github-actions bot added the normalization label Jan 5, 2022

marcosmarxm temporarily deployed to more-secrets January 5, 2022 03:13 Inactive

jrhizor temporarily deployed to more-secrets January 5, 2022 03:17 Inactive

scd fix for all destinations

d8bb53f

marcosmarxm temporarily deployed to more-secrets January 5, 2022 03:43 Inactive

jrhizor temporarily deployed to more-secrets January 5, 2022 03:44 Inactive

ChristopheDuong suggested changes Jan 5, 2022

View reviewed changes

...te-integrations/bases/base-normalization/normalization/transform_catalog/stream_processor.py Outdated Show resolved Hide resolved

marcosmarxm added 2 commits January 5, 2022 09:09

use quote

e6b0407

use normalize column for post-hook

745fbf7

marcosmarxm temporarily deployed to more-secrets January 5, 2022 18:06 Inactive

jrhizor temporarily deployed to more-secrets January 5, 2022 18:07 Inactive

ChristopheDuong reviewed Jan 5, 2022

View reviewed changes

change logic to apply quote

96df256

marcosmarxm temporarily deployed to more-secrets January 6, 2022 01:19 Inactive

add logic to handle prefix for mssql and oracle

8495633

marcosmarxm temporarily deployed to more-secrets January 6, 2022 16:12 Inactive

jrhizor temporarily deployed to more-secrets January 6, 2022 16:14 Inactive

ChristopheDuong approved these changes Jan 6, 2022

View reviewed changes

marcosmarxm added 2 commits January 6, 2022 15:56

run tests

8f14292

merge master

d06c537

marcosmarxm temporarily deployed to more-secrets January 6, 2022 18:59 Inactive

correct unit test

5fee2a6

marcosmarxm temporarily deployed to more-secrets January 6, 2022 20:46 Inactive

jrhizor temporarily deployed to more-secrets January 6, 2022 20:47 Inactive

marcosmarxm added 2 commits January 6, 2022 19:27

Merge branch 'master' into marcos/normalization-snowflake-startwith-n…

89cbcdb

…umber

bump normalization version

29e047d

github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jan 6, 2022

marcosmarxm temporarily deployed to more-secrets January 6, 2022 22:31 Inactive

jrhizor temporarily deployed to more-secrets January 6, 2022 22:33 Inactive

marcosmarxm temporarily deployed to more-secrets January 7, 2022 00:15 Inactive

marcosmarxm merged commit 511819b into master Jan 7, 2022

marcosmarxm deleted the marcos/normalization-snowflake-startwith-number branch January 7, 2022 02:39

jrhizor mentioned this pull request Jan 7, 2022

Bump Airbyte version from 0.35.3-alpha to 0.35.4-alpha #9353

Merged

karinakuz added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalization fix Snowflake Prefix Tables starting with number #9301

Normalization fix Snowflake Prefix Tables starting with number #9301

marcosmarxm commented Jan 5, 2022 •

edited

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

ChristopheDuong Jan 5, 2022

marcosmarxm Jan 5, 2022

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading

Normalization fix Snowflake Prefix Tables starting with number #9301

Normalization fix Snowflake Prefix Tables starting with number #9301

Conversation

marcosmarxm commented Jan 5, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

marcosmarxm commented Jan 5, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 5, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 5, 2022 • edited by github-actions bot Loading

ChristopheDuong Jan 5, 2022

Choose a reason for hiding this comment

marcosmarxm Jan 5, 2022

Choose a reason for hiding this comment

marcosmarxm commented Jan 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 5, 2022 •

edited

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 5, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 6, 2022 •

edited by github-actions bot

Loading