Run the 'Release Airbyte' workflow on EC2 runners #9361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems right! Kinda jenky - the easiest way to test this is to comment out the gradle publish and the docker push steps in the Remember to close the created PR and leave a comment saying you were testing things out. |
|
@davinchia it looks like the ec2 runner that spins up doesn't have pip installed, so I added
Does that look alright to you? |
|
yeap! |
davinchia
approved these changes
Jan 11, 2022
pmossman
force-pushed
the
parker/release-os-on-ec2-runner
branch
from
9dfeb99
to
6b8ec7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The platform team discussed frustratingly-long release time in our last retrospective. By running the release workflow on self-hosted EC2 runners, we should be able to speed things up quite a bit.
How
Add steps to start and stop ec2 runners to the
release-airbyte-os.yamlworkflow definition, like we do for other intensive github workflows.@davinchia let me know how this looks, and if you have any pointers for testing this out!