Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸŽ‰ SurveyMonkey source: scopes change #9508

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

annalvova05
Copy link
Contributor

@annalvova05 annalvova05 commented Jan 14, 2022

What

We need to remove the scopes we do not use from the SurveyMonkey connector. This is the requirement from the support team to make our App Public.

How

Change check method for the connector.

Recommended reading order

  1. source.py

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here


This change is Reviewable

@annalvova05 annalvova05 linked an issue Jan 14, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 14, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 14, 2022
@annalvova05 annalvova05 temporarily deployed to more-secrets January 14, 2022 10:13 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Jan 17, 2022

/test connector=connectors/source-surveymonkey

πŸ•‘ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1707452861
βœ… connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1707452861
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                              Stmts   Miss  Cover
	 -----------------------------------------------------
	 source_surveymonkey/__init__.py       2      0   100%
	 source_surveymonkey/source.py        35     19    46%
	 source_surveymonkey/streams.py      145     86    41%
	 -----------------------------------------------------
	 TOTAL                               182    105    42%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 14 passed, 1 skipped in 98.10s (0:01:38) ===================

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 10:29 Inactive
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change something inside of Oauth part of java side for this connector, in terms of scopes?

@bazarnov bazarnov self-requested a review January 17, 2022 10:50
@annalvova05
Copy link
Contributor Author

Do we need to change something inside of Oauth part of java side for this connector, in terms of scopes?

@bazarnov no, we needn't pass scopes to receive access_token for oAuth.

Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annalvova05 , Please publish your changes

@annalvova05
Copy link
Contributor Author

annalvova05 commented Jan 17, 2022

/publish connector=connectors/source-surveymonkey

πŸ•‘ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1708824978
βœ… connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/1708824978

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 15:59 Inactive
@annalvova05 annalvova05 merged commit edc0925 into master Jan 17, 2022
@annalvova05 annalvova05 deleted the alvova/9505-surveymonkey-scopes branch January 17, 2022 16:17
@annalvova05 annalvova05 temporarily deployed to more-secrets January 17, 2022 16:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SurveyMonkey source: scopes change
4 participants