Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Bing-Ads: fixed broken dependency #9510

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

bazarnov
Copy link
Collaborator

What

#9509

How

By changing bingads~=13.0.11 instead of bingads==13.0.10

🚨 User Impact 🚨

Just update the connector, no other steps required.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Jan 14, 2022
@bazarnov bazarnov linked an issue Jan 14, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 14, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 14, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jan 14, 2022

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1697445707
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1697445707
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_bing_ads/__init__.py       2      0   100%
	 source_bing_ads/cache.py         18      3    83%
	 source_bing_ads/client.py        87     33    62%
	 source_bing_ads/reports.py      115     53    54%
	 source_bing_ads/source.py       252     83    67%
	 -------------------------------------------------
	 TOTAL                           474    172    64%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 14 passed, 1 skipped in 178.25s (0:02:58) ===================

@bazarnov bazarnov requested a review from antixar January 14, 2022 11:26
@bazarnov bazarnov temporarily deployed to more-secrets January 14, 2022 11:27 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 14, 2022 11:28 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jan 14, 2022

/publish connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1697495485
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1697495485

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 14, 2022 11:42 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 14, 2022 11:54 Inactive
@bazarnov bazarnov merged commit 6fc9889 into master Jan 14, 2022
@bazarnov bazarnov deleted the bazarnov/bing-ads-dependency-fix branch January 14, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Bing Ads: Check failed
3 participants