Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source HubSpot: Add more fields for email_events stream #9641

Merged
merged 8 commits into from
Jan 21, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jan 20, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

I have added more fields which not described in HubSpot documentation.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 20, 2022
@grubberr grubberr self-assigned this Jan 20, 2022
@grubberr grubberr linked an issue Jan 20, 2022 that may be closed by this pull request
@grubberr grubberr temporarily deployed to more-secrets January 20, 2022 12:01 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 20, 2022
@grubberr grubberr changed the title 🎉 Source HubSpot: improve stream schemas based on analyzing real data 🎉 Source HubSpot: Add more fields for email_events stream Jan 20, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 20, 2022 19:17 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 20, 2022 19:19 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grubberr thanks for the fix! can you please fill out the PR template? It is super important to fill it out to retain context and call out customer impacting changes

@grubberr
Copy link
Contributor Author

grubberr commented Jan 20, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725200598
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725200598
🐛 https://gradle.com/s/pvoki3iluxk5c
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Please check...
=================== 2 failed, 19 passed in 81.45s (0:01:21) ====================

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 20, 2022 19:27 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 20, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725440461
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725440461
🐛 https://gradle.com/s/lktrbgbpykl4i

@grubberr grubberr temporarily deployed to more-secrets January 20, 2022 20:29 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 20, 2022 20:30 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jan 20, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725524809
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1725524809
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_hubspot/__init__.py       2      0   100%
	 source_hubspot/api.py          518    113    78%
	 source_hubspot/client.py        40     12    70%
	 source_hubspot/errors.py         6      0   100%
	 source_hubspot/source.py         4      0   100%
	 ------------------------------------------------
	 TOTAL                          570    125    78%

@grubberr grubberr temporarily deployed to more-secrets January 20, 2022 20:52 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 20, 2022 20:53 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grubberr
Copy link
Contributor Author

grubberr commented Jan 21, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1729753541
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1729753541

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 21, 2022 16:44 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 21, 2022 17:20 Inactive
@grubberr grubberr requested review from sherifnada and removed request for sherifnada January 21, 2022 17:21
@antixar antixar requested review from sherifnada and removed request for sherifnada January 21, 2022 17:28
@antixar antixar dismissed sherifnada’s stale review January 21, 2022 17:32

checklist was filled.

@grubberr grubberr merged commit c524e0a into master Jan 21, 2022
@grubberr grubberr deleted the grubberr/9640-source-hubspot branch January 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉 Source HubSpot: Add more fields for email_events stream
5 participants