Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 🎉 Source FB Marketing: performance and reliability fixes #9805

Merged
merged 73 commits into from
Feb 17, 2022
Merged

🎉 🎉 Source FB Marketing: performance and reliability fixes #9805

merged 73 commits into from
Feb 17, 2022

Commits on Dec 3, 2021

  1. Facebook Marketing performance improvement

    Dmytro Rezchykov committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    57b47cb View commit details
    Browse the repository at this point in the history

  2. add comments and little refactoring 

    Bump version
    Dmytro Rezchykov committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    69b2958 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. fix after performance test

    Dmytro Rezchykov committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    440fc6e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Check job status in advance, some other changes.

    Dmytro Rezchykov committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    dff2421 View commit details
    Browse the repository at this point in the history

  2. Bump rc version

    Dmytro Rezchykov committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    4112279 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. fix usage of AsyncJob methods, correct batch job retry

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    939d646 View commit details
    Browse the repository at this point in the history

  2. bump dev version

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    0f8439d View commit details
    Browse the repository at this point in the history

  3. revert extra diff with master

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    86ce7db View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into drezchykov/fb-perf

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    fa650b8 View commit details
    Browse the repository at this point in the history

  5. fix bad merge

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d8f57d6 View commit details
    Browse the repository at this point in the history

  6. isort

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5c7e18f View commit details
    Browse the repository at this point in the history

  7. fix flake

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    c9deade View commit details
    Browse the repository at this point in the history

  8. fix unit tests

    @eugene-kulak
    eugene-kulak committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    07acea5 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. fix integration tests with the new config

    @eugene-kulak
    eugene-kulak committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    213ac36 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. improve job status handling, limit concurrency to 10

    @eugene-kulak
    eugene-kulak committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    93a03e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. WIP

    @eugene-kulak
    eugene-kulak committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    47ad837 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. fix campaign jobs, refactor manager

    @eugene-kulak
    eugene-kulak committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    483f5cd View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. big refactoring of async jobs, support random order of slices

    @eugene-kulak
    eugene-kulak committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    4faabcb View commit details
    Browse the repository at this point in the history

  2. update source _read_incremental to hook new state logic

    @eugene-kulak
    eugene-kulak committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    ea1ac91 View commit details
    Browse the repository at this point in the history

  3. fix issues with timeout

    @eugene-kulak
    eugene-kulak committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    c7ca0e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. remove debugging and clean up, improve retry logic

    @eugene-kulak
    eugene-kulak committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f66ce53 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into drezchykov/fb-perf

    @eugene-kulak
    eugene-kulak committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    cc5baea View commit details
    Browse the repository at this point in the history

  3. merge changes from #8234

    @eugene-kulak
    eugene-kulak committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    218db5c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. fix call super _read_increment

    @eugene-kulak
    eugene-kulak committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    2e56c22 View commit details
    Browse the repository at this point in the history

  2. generalize batch execution, add use_batch flag 

    fix SAT
    @eugene-kulak
    eugene-kulak committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    8d560d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. fixing unittests

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    3c0754d View commit details
    Browse the repository at this point in the history

  2. fix integration tests

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    1 Configuration menu
    Copy the full SHA
    76b529c View commit details
    Browse the repository at this point in the history

  3. fix tests for AsyncJob

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    ca42a4e View commit details
    Browse the repository at this point in the history

  4. fix unit_tests and batch yield

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    15e73f1 View commit details
    Browse the repository at this point in the history

  5. fix SAT

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    d09994f View commit details
    Browse the repository at this point in the history

  6. fix flake

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    06a75ef View commit details
    Browse the repository at this point in the history

  7. format

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    1 Configuration menu
    Copy the full SHA
    ae503c3 View commit details
    Browse the repository at this point in the history

  8. refactor file layout and fix formatting

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    8df71c9 View commit details
    Browse the repository at this point in the history

  9. format

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    01f8bd4 View commit details
    Browse the repository at this point in the history

  10. format

    @eugene-kulak
    eugene-kulak committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    3cbd8fc View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. improve coverage, do some refactoring of spec

    @eugene-kulak
    eugene-kulak committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a969afa View commit details
    Browse the repository at this point in the history

  2. small fix

    @eugene-kulak
    eugene-kulak committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    67841e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. format

    @eugene-kulak
    eugene-kulak committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    da19125 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into keu/source-fb-perfo… 

    …rmance-8282
    @eugene-kulak
    eugene-kulak committed Jan 26, 2022
    1 Configuration menu
    Copy the full SHA
    3f038c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. WIP

    @eugene-kulak
    eugene-kulak committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    af9e988 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. WIP

    @eugene-kulak
    eugene-kulak committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    b728348 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. update test, remove overrides of source

    @eugene-kulak
    eugene-kulak committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    780596f View commit details
    Browse the repository at this point in the history

  2. format

    @eugene-kulak
    eugene-kulak committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    9aa7307 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into keu/source-fb-perfo… 

    …rmance-8282
    @eugene-kulak
    eugene-kulak committed Jan 31, 2022
    1 Configuration menu
    Copy the full SHA
    c2c6833 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. fix code smell

    @eugene-kulak
    eugene-kulak committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    2a4bf87 View commit details
    Browse the repository at this point in the history

  2. address comments from @sherifnada

    @eugene-kulak
    eugene-kulak committed Feb 3, 2022
    1 Configuration menu
    Copy the full SHA
    58b21c2 View commit details
    Browse the repository at this point in the history

  3. address comments from @sherifnada

    @eugene-kulak
    eugene-kulak committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    918720d View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. fix after small refactoring

    @eugene-kulak
    eugene-kulak committed Feb 4, 2022
    1 Configuration menu
    Copy the full SHA
    8812763 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @eugene-kulak
    eugene-kulak committed Feb 4, 2022
    1 Configuration menu
    Copy the full SHA
    16b7dc1 View commit details
    Browse the repository at this point in the history

  3. add split by AdSet

    @eugene-kulak
    eugene-kulak committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    8782919 View commit details
    Browse the repository at this point in the history

  4. add smaller insights

    @eugene-kulak
    eugene-kulak committed Feb 4, 2022
    1 Configuration menu
    Copy the full SHA
    d623abd View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. address comments from @sherifnada

    @eugene-kulak
    eugene-kulak committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    529f773 View commit details
    Browse the repository at this point in the history

  2. address comments from @sherifnada

    @eugene-kulak
    eugene-kulak committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    a192588 View commit details
    Browse the repository at this point in the history

  3. format

    @eugene-kulak
    eugene-kulak committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    0f2bcbc View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. fix batch loop

    @eugene-kulak
    eugene-kulak committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cb5bc4b View commit details
    Browse the repository at this point in the history

  2. fix tests

    @eugene-kulak
    eugene-kulak committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    780ee72 View commit details
    Browse the repository at this point in the history

  3. cover last bit of async_job

    @eugene-kulak
    eugene-kulak committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f6bcaba View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. fix end_date < start_date case

    @eugene-kulak
    eugene-kulak committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2f1453b View commit details
    Browse the repository at this point in the history

  2. format

    @eugene-kulak
    eugene-kulak committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    dea05a8 View commit details
    Browse the repository at this point in the history

  3. add account_id to PK

    @eugene-kulak
    eugene-kulak committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    d3c2f92 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. address comment from @sherifnada

    @eugene-kulak
    eugene-kulak committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    52b000f View commit details
    Browse the repository at this point in the history

  2. fix tests

    @eugene-kulak
    eugene-kulak committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9544c1a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Merge remote-tracking branch 'origin/master' into keu/source-fb-perfo… 

    …rmance-8282
    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    f88cf21 View commit details
    Browse the repository at this point in the history

  2. fix streams after merge

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    195e8ac View commit details
    Browse the repository at this point in the history

  3. fix tests

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    9edaf8f View commit details
    Browse the repository at this point in the history

  4. add notes

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    1b5431f View commit details
    Browse the repository at this point in the history

  5. fix new streams

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    63ea958 View commit details
    Browse the repository at this point in the history

  6. format

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    c4e8ce2 View commit details
    Browse the repository at this point in the history

  7. fix reversed incremental stream

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    2d04abd View commit details
    Browse the repository at this point in the history

  8. update spec.json for SAT

    @eugene-kulak
    eugene-kulak committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    5101e85 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. upgrade CDK and bump version

    @eugene-kulak
    eugene-kulak committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    3d92326 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. bump version

    @eugene-kulak
    eugene-kulak committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    2e119a8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into keu/source-fb-perfo… 

    …rmance-8282

# Conflicts:
#	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e7778cfc-e97c-4458-9ecb-b4f2bba8946c.json
    @eugene-kulak
    eugene-kulak committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    6965ef4 View commit details
    Browse the repository at this point in the history