Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: file-secure #9809

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

grubberr
Copy link
Contributor

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Add title and description properties to each field in source-connectors specifications:
file-secure

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Jan 26, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 26, 2022
@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 07:38 Inactive
@grubberr grubberr linked an issue Jan 26, 2022 that may be closed by this pull request
@grubberr
Copy link
Contributor Author

grubberr commented Jan 26, 2022

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1749623861
❌ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1749623861
🐛 https://gradle.com/s/slji6oqdagpri
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: Co...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 13 passed, 2 skipped in 14.68s ===================

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@c021426). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9809   +/-   ##
=========================================
  Coverage          ?   35.13%           
=========================================
  Files             ?        5           
  Lines             ?      333           
  Branches          ?        0           
=========================================
  Hits              ?      117           
  Misses            ?      216           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c021426...8a890b8. Read the comment docs.

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 07:42 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Feb 1, 2022

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1779625824
❌ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1779625824
🐛 https://gradle.com/s/bjns4zljrp7f4
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: Co...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 19 passed, 2 skipped in 20.49s ===================

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 17:08 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 1, 2022 17:11 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Feb 1, 2022

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1779858292
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1779858292
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              275    106    61%
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  70     17    76%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                 1032    415    60%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                             Stmts   Miss  Cover
	 ----------------------------------------------------
	 source_file_secure/__init__.py       2      0   100%
	 source_file_secure/source.py        45      8    82%
	 ----------------------------------------------------
	 TOTAL                               47      8    83%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 20 passed, 2 skipped in 19.32s ========================

@grubberr grubberr temporarily deployed to more-secrets February 1, 2022 17:55 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 1, 2022 17:56 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Feb 2, 2022

/publish connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1783200578
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/1783200578

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 09:54 Inactive
@grubberr grubberr merged commit 16df414 into master Feb 2, 2022
@grubberr grubberr deleted the grubberr/issue-9783-update-title-description branch February 2, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: file-secure
3 participants