Add progress bar #9983
Add progress bar #9983
Conversation
github-actions
bot
added
area/frontend
area/platform
| @@ -19,7 +19,7 @@ const FetchMessage = styled.div` | |||
|
|
|||
| const LoadingSchema: React.FC = () => ( | |||
| <SpinnerBlock> | |||
| <Spinner /> | |||
| <ProgressBar runTime={120} /> | |||
There was a problem hiding this comment.
Can we make this 4min when running discover? 2min seems good for check connection.
| @@ -19,7 +19,7 @@ const FetchMessage = styled.div` | |||
|
|
|||
| const LoadingSchema: React.FC = () => ( | |||
| <SpinnerBlock> | |||
| <Spinner /> | |||
| <ProgressBar runTime={240} /> | |||
There was a problem hiding this comment.
Could we please leave an inline comment here in code how we got to this rather arbitrary number? Like that this is an experience based amount of time this task usually runs, but so we'll be able in the future to understand where this number was coming from.
There was a problem hiding this comment.
Hehe, I believe we need to ask @jrhizor for such info.
There was a problem hiding this comment.
This number just is purely a middle-of-the-road estimate based off of personal experiences running checks/discover across docker-compose OSS / kube OSS / cloud. In the future we can tune this based off of run durations when we actually capture them.
Co-authored-by: Tim Roes <mail@timroes.de>
Co-authored-by: Jared Rhizor <jared@dataline.io>
What
Add Progress Bar for checking connection and running the discover schema
If the ProgressBar is full and process has not ended, the message will appear.
Closes #9756