airmon-ng.linux: in a for loop, replace ls with a glob

[wileyhy]

The [ -e syntax covers the case of when the glob produces no matches and sh uses the glob pattern itself as a value for "$i".

xtrace comparison:

original

set -x; 
for i in $(ls /sys/class/ieee80211/); do 
  if [ ! -d "/sys/class/ieee80211/${i}/device/net" ]; then 
    MISSING_INTERFACE="${i}"; 
    echo "$MISSING_INTERFACE" :: "$i"; 
  fi; 
done; 
set - 

++ ls --color=auto /sys/class/ieee80211/
+ for i in $(ls /sys/class/ieee80211/)
+ '[' '!' -d /sys/class/ieee80211/phy0/device/net ']'
+ set -

change added

set -x; 
for i in /sys/class/ieee80211/*; do 
  if [ -e "${i}" ] && [ ! -d "${i}/device/net" ]; then 
    MISSING_INTERFACE="${i}"; 
    echo "$MISSING_INTERFACE" :: "$i"; 
  fi; 
done; 
set -

+ for i in /sys/class/ieee80211/*
+ '[' -e /sys/class/ieee80211/phy0 ']'
+ '[' '!' -d /sys/class/ieee80211/phy0/device/net ']'
+ set -

Edit 1: formatting
Edit 2: note re [ -e syntax

[ZeroChaos-]

This is a good start, but unfortunately it entirely breaks the function

+ iw phy /sys/class/ieee80211/phy0 interface add wlan0mon type monitor
+ IW_ERROR='command failed: No such file or directory (-2)' 
+ '[' -z 'command failed: No such file or directory (-2)' ']'
+ printf '\n\n ERROR adding %s mode interface: %s\n' monitor 'command failed: No such file or directory (-2)'

Also, please remove the two comments above your change since the comments are suggesting to do exactly what you are trying to do :-)

[ZeroChaos-]

Please fix setting MISSING_INTERFACE to the expected value. You changed the meaning of ${i} but didn't update it's use everywhere

[wileyhy]

You're right; thank you. Two fixes have commits up for review.

[ZeroChaos-]

tested on zsh, dash, bash, and mksh

Looks great, thanks!

[ZeroChaos-]

merging, one unrelated check failure

[ZeroChaos-]

thanks @wileyhy

[wileyhy]

You're welcome! Thank _you_! :-)

…

On Wed, Jul 19, 2023, 11:59 AM Zero_Chaos ***@***.***> wrote: thanks @wileyhy <https://github.com/wileyhy> — Reply to this email directly, view it on GitHub <#2551 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUF2F253NEEOA2FBBJJONQTXRAVBRANCNFSM6AAAAAA2D2HGQQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>