Skip to content

Commit

Permalink
test: test the "ct lint-and-install --all --target-branch main"
Browse files Browse the repository at this point in the history
Signed-off-by: chirichidi <tolessnoise@gmail.com>
  • Loading branch information
chirichidi committed Feb 20, 2024
1 parent ef6a6b8 commit 6e6bc87
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
12 changes: 6 additions & 6 deletions charts/airflow/sample-values-CeleryExecutor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ airflow:
## a list of users to create
## [FAQ] https://github.com/airflow-helm/charts/blob/main/charts/airflow/docs/faq/security/airflow-users.md
users:
- username: admin
password: admin
role: Admin
email: admin@example.com
firstName: admin
lastName: admin
- username: admin
password: admin
role: Admin
email: admin@example.com
firstName: admin
lastName: admin

## a list airflow connections to create
## [FAQ] https://github.com/airflow-helm/charts/blob/main/charts/airflow/docs/faq/dags/airflow-connections.md
Expand Down
2 changes: 1 addition & 1 deletion charts/airflow/templates/_helpers/pods.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ EXAMPLE USAGE: {{ include "airflow.container.s3_sync" (dict "Release" .Release "
valueFrom:
secretKeyRef:
name: {{ .Values.dags.s3Sync.profile }}
key: {{ .Values.dags.s3Sync.idKey }}
key: {{ .Values.dags.s3Sync.accessKey }}
- name: AWS_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/airflow/templates/_helpers/validate-values.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
{{ required "If `dags.s3Sync.enabled=true`, then `persistence.enabled` must be disabled!" nil }}
{{- end }}
{{- if not .Values.dags.s3Sync.bucket }}
{{ required "If `dags.s3Sync.enabled=true`, then `dags.gitSync.bucket` must be non-empty!" nil }}
{{ required "If `dags.s3Sync.enabled=true`, then `dags.s3Sync.bucket` must be non-empty!" nil }}
{{- end }}
{{- end }}

Expand Down
18 changes: 9 additions & 9 deletions charts/airflow/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1464,7 +1464,7 @@ dags:
## configs for a sync from s3 object storage
##
s3Sync:
## if the git-sync sidecar container is enabled
## if the s3-sync sidecar container is enabled
##
enabled: false

Expand All @@ -1474,10 +1474,10 @@ dags:
repository: amazon/aws-cli
tag: 2.13.15
pullPolicy: IfNotPresent
uid: 65533
gid: 65533
uid: 50000
gid: 0

## resource requests/limits for the git-sync container
## resource requests/limits for the s3-sync container
## - spec for ResourceRequirements:
## https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.20/#resourcerequirements-v1-core
##
Expand All @@ -1497,22 +1497,22 @@ dags:
##
## ____ EXAMPLE _______________
## # s3 sub path
## s3Path: "s3://<bucket>/<path>/<to>/<dags>"
## s3Path: "s3://<bucket>/<s3Path>"
##
bucket: ""
s3Path: ""

## Due to the issue where keys must consist of alphanumeric characters, and for security reasons,
## it is strongly recommended to inject Secrets into Pods' environment variables from external services like ExternalSecrets.
## This approach ensures sensitive information is securely managed and not embedded within source code or values.yaml,
## Due to the issue where keys must consist of alphanumeric characters, and for security reasons
## it is strongly recommended to inject Secrets into Pods' environment variables from external services like ExternalSecrets.
## This approach ensures sensitive information is securely managed and not embedded within source code or values.yaml,
## aligning with best practices for secure application configuration.
##
## the name of the pre-created Secret with AWS credentials
profile: ""

## the key in `dags.s3Sync.profile` with your access key id
##
idKey: keyId
accessKey: accessKey

## the key in `dags.s3Sync.profile` with your secret access key
##
Expand Down

0 comments on commit 6e6bc87

Please sign in to comment.