feat: add airflow.kubernetesPodTemplate.extraInitContainers
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcgrath207
changed the title
jmcgrath207
force-pushed
the
main
branch
2 times, most recently
from
68a2c81
to
2ef8cf8
Compare
|
Hey @thesuperzapper @gsemet , is there anything else I need to do to get this merged? |
thesuperzapper
requested changes
Nov 11, 2021
There was a problem hiding this comment.
@jmcgrath207 thanks for the PR, I have left a small fix that is needed before we can merge.
thesuperzapper
changed the title
kubernetesPodTemplate.extraInitContainers
thesuperzapper
changed the title
kubernetesPodTemplate.extraInitContainers
thesuperzapper
moved this from Working On | Mathew
to Waiting for Changes
in Issue Triage and PR Tracking
jmcgrath207
commented
Nov 19, 2021
|
@jmcgrath207 thanks for your work! I will put this in the 8.6.0 milestone (as it adds a new value). |
thesuperzapper
moved this from Waiting for Changes
to Waiting to Merge
in Issue Triage and PR Tracking
thesuperzapper
changed the title
airflow.kubernetesPodTemplate.extraInitContainers
Issue Triage and PR Tracking
automation
moved this from PR | Ready to Merge
to PR | Waiting For Review
Dec 15, 2021
thesuperzapper
requested changes
Dec 15, 2021
There was a problem hiding this comment.
@jmcgrath207 I just realized you were not correctly referencing the value you created.
The value is airflow.kubernetesPodTemplate.extraInitContainers, not kubernetesPodTemplate.extraInitContainers.
thesuperzapper
moved this from PR | Waiting For Review
to PR | Waiting for Changes
in Issue Triage and PR Tracking
|
@jmcgrath207 do you still have time to apply the changes needed to address comments in #446 (review)? |
Issue Triage and PR Tracking
automation
moved this from PR | Waiting for Changes
to Done
Feb 24, 2022
thesuperzapper
moved this from Unsorted
to PR | Waiting for Changes
in Issue Triage and PR Tracking
Signed-off-by: John McGrath <john.mcgrath207@gmail.com>
thesuperzapper
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
@jmcgrath207 I have gone ahead and fixed your PR, so it can be merged for 8.6.0.
Issue Triage and PR Tracking
automation
moved this from PR | Waiting for Changes
to PR | Ready to Merge
Mar 22, 2022
thesuperzapper
added
the
status/ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
N/A
What does your PR do?
airflow.kubernetesPodTemplate.extraInitContainersvalue to specify extra init-containers in the KubernetesExecutor pod_template.Checklist
For all Pull Requests
For releasing ONLY