feat: allow labels on sync and db-migrations Deployments/Jobs
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrkovalenko
requested review from
gsemet and
thesuperzapper
as code owners
oleksandrkovalenko
changed the title
Signed-off-by: Oleksandr Kovalenko <oleksandr.kovalenko@gmail.com>
oleksandrkovalenko
force-pushed
the
labels
branch
from
fce47e8
to
fc59cee
Compare
oleksandrkovalenko
changed the title
thesuperzapper
changed the title
thesuperzapper
changed the title
sync and db-migrations Deployments/Jobs
thesuperzapper
requested changes
Dec 15, 2021
There was a problem hiding this comment.
@oleksandrkovalenko thanks for the PR!
However, you have missed a adding the labels to the Job resources:
- https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/db-migrations/db-migrations-job.yaml
- https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/sync/sync-connections-job.yaml
- https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/sync/sync-pools-job.yaml
- https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/sync/sync-users-job.yaml
- https://github.com/airflow-helm/charts/blob/main/charts/airflow/templates/sync/sync-variables-job.yaml
Can you please add the labels to these resources also?
thesuperzapper
moved this from PR | Waiting For Review
to PR | Waiting for Changes
in Issue Triage and PR Tracking
Signed-off-by: Oleksandr Kovalenko <oleksandr.kovalenko@gmail.com>
|
@thesuperzapper I just make the changes. Could you please check them |
thesuperzapper
moved this from PR | Waiting for Changes
to PR | Waiting For Review
in Issue Triage and PR Tracking
|
Could somebody please take a look at this one. The issue was already marked as staled. Sorry, I just afraid it will be forgotten. Many thanks |
thesuperzapper
previously approved these changes
Feb 17, 2022
There was a problem hiding this comment.
@oleksandrkovalenko thanks for the PR, it looks good-to-go for the 8.6.0 release, I will put it in "ready to merge", and merge it just before we cut the release.
Issue Triage and PR Tracking
automation
moved this from PR | Waiting For Review
to PR | Ready to Merge
Feb 17, 2022
thesuperzapper
added
the
status/ready-to-merge
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Issue Triage and PR Tracking
automation
moved this from PR | Ready to Merge
to PR | Needs Review
Apr 1, 2022
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
syncanddb-migrationsDeployments/Jobs #466What does your PR do?
syncanddb-migrationsDeployments/Jobs:airflow.dbMigrations.labelsairflow.sync.labelspgbouncer.labelsvalue so that it is respectedChecklist
For all Pull Requests
For releasing ONLY