fix: allow ingress servicePort to be string or number
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
thesuperzapper
moved this from Unsorted
to PR | Ready to Merge
in Issue Triage and PR Tracking
thesuperzapper
added
the
status/ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
ingress.web.precedingPaths[].servicePortis specified as a string #477What does your PR do?
When we migrated to the
networking.k8s.io/v1version of Ingress, we incorrectly assumed thatingress.web.precedingPaths[].servicePortwould always be a number, when previously it could be a port-name also.This PR, ensure that we place the
servicePortinto the correct Ingress field, depending on if it is a string or a number.Checklist
For all Pull Requests
For releasing ONLY