Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default pgbouncer.maxClientConnections to 1000 #543

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Mar 22, 2022

What issues does your PR fix?

  • N/A

What does your PR do?

  • Increases the default pgbouncer.maxClientConnections from 100 to 1000
    • NOTE: 1000 is well beyond what should be required in most deployments, so this should prevent users from running into a confusing situation where the connection limit is exceeded, and random things start failing (with the only error logs being in the PGBouncer deployment)

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Mar 22, 2022
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Mar 22, 2022
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Mar 22, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 22, 2022
@thesuperzapper thesuperzapper changed the title feat: set default pgbouncer.maxClientConnections to 1000 feat: increase default pgbouncer.maxClientConnections to 1000 Mar 22, 2022
@thesuperzapper thesuperzapper changed the title feat: increase default pgbouncer.maxClientConnections to 1000 feat: set default pgbouncer.maxClientConnections to 1000 Mar 22, 2022
@thesuperzapper thesuperzapper merged commit c9a4d5f into airflow-helm:main Mar 31, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Mar 31, 2022
@thesuperzapper thesuperzapper deleted the pgbouncer-max-conn-1000 branch April 1, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant