Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "task creation check" to scheduler liveness probe #549

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Mar 25, 2022

What issues does your PR fix?

What does your PR do?

  • Adds an optional "task creation check" to the scheduler liveness probe:
    • scheduler.livenessProbe.taskCreationCheck.enabled (default: false)
    • scheduler.livenessProbe.taskCreationCheck.thresholdSeconds (default: 300)
  • Adds a new FAQ "How to configure the scheduler liveness probe?" with sub-sections:
    • Scheduler "Heartbeat Check"
    • Scheduler "Task Creation Check"
  • Runs the scheduler livenessProbe with /entrypoint:
    • NOTE: this ensures any fixes inside /entrypoint are applied in our livenessProbe
    • NOTE: this improves support for running as root (airflow python packages will not be visible otherwise)
  • Makes the scheduler livenessProbe use fewer resources by:
    1. Only querying the .first() instance of SchedulerJob from the database
    2. Setting airflow log-level to ERROR
    3. Running python under dumb-init (so processes are cleaned up)

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Mar 25, 2022
@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Mar 25, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 25, 2022
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Mar 25, 2022
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper merged commit f870c67 into airflow-helm:main Mar 31, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Mar 31, 2022
@thesuperzapper thesuperzapper deleted the task-creation-scheduler-probe branch March 31, 2022 23:23
@thesuperzapper thesuperzapper mentioned this pull request Apr 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant