Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: database passwords with values + username from secret #553

Merged
merged 2 commits into from
Mar 31, 2022
Merged

feat: database passwords with values + username from secret #553

merged 2 commits into from
Mar 31, 2022

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Mar 29, 2022 •
edited

What issues does your PR fix?

What does your PR do?

  • Added values to set externalDatabase/externalRedis passwords directly with plain-text values:
    • externalDatabase.password
    • externalRedis.password
  • Added values to set externalDatabase username from a secret:
    • externalDatabase.userSecret
    • externalDatabase.userSecretKey (default: postgresql-user)
  • Added warning to NOTES.txt if user sets externalDatabase/externalRedis using the plain-text values.

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper
feat: set db password with value + db user from secret
a4ba296 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Mar 29, 2022
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Mar 29, 2022
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Mar 29, 2022
@thesuperzapper thesuperzapper mentioned this pull request Mar 29, 2022
Closed
6 tasks
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 29, 2022
@thesuperzapper
feat: set db password with value + db user from secret
a020b5f 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper changed the title feat: set db password with value + db user from secret feat: database passwords with values + username from secret Mar 31, 2022
@thesuperzapper thesuperzapper merged commit b4f2b98 into airflow-helm:main Mar 31, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Mar 31, 2022
@thesuperzapper thesuperzapper deleted the external-database-user-secret branch April 1, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/ready-to-merge status - this will be merged into next release
Projects
Issue Triage and PR Tracking
Done
Milestone
airflow-8.6.0
Development

Successfully merging this pull request may close these issues.

specify externalDatabase username from Secret (improves PostgresOperator support)
1 participant
@thesuperzapper