Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set SQLALCHEMY_DATABASE_URI in airflow 1.10 #609

Merged

Conversation

thesuperzapper
Copy link
Member

What issues does your PR fix?

  • N/A

What does your PR do?

  • Updates the default webserver_config.py template to only set SQLALCHEMY_DATABASE_URI when airflow.legacyCommands is true (as it only needs to be set for airflow 1.10).

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Jun 14, 2022
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Jun 14, 2022
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Jun 14, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 14, 2022
@thesuperzapper thesuperzapper changed the title fix: only set SQLALCHEMY_DATABASE_URI in 1.10 fix: only set SQLALCHEMY_DATABASE_URI in airflow 1.10 Jun 22, 2022
@thesuperzapper thesuperzapper merged commit 00863c9 into airflow-helm:main Jun 22, 2022
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Jun 22, 2022
@thesuperzapper thesuperzapper deleted the only-set-sqlalchemy-in-1.10 branch June 22, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant