fix: liveness probes in airflow 2.6.0 #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
This was referenced May 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
This PR fixes support for airflow 2.6.0 in the chart. Due to PR apache/airflow#30302, airflow's Job objects
SchedulerJobandTriggererJobwere changed so they are now wrapped in anXXXXJobRunnerobject, which broke our scheduler and triggerer liveness probes.There is a related upstream airflow issue apache/airflow#31200 introduced by Airflow 2.6.0 (which can't really be fixed by this chart), the details of that issue are explained in apache/airflow#31200 (comment), so you should strongly consider waiting for at least 2.6.1 before upgrading.
After this PR the liveness probes for the scheduler and triggerer will not always fail.
Checklist
For all Pull Requests