Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync-users for airflow 2.7.0 #772

Merged

Conversation

SamWheating
Copy link
Contributor

@SamWheating SamWheating commented Aug 23, 2023

What issues does your PR fix?

What does your PR do?

Updates this import path to be Airflow 2.7.0-friendly

Checklist

For all Pull Requests

For releasing ONLY

@SamWheating SamWheating force-pushed the sw-fix-broken-imports-sync-users branch 2 times, most recently from 1ccdb03 to 4a0fb46 Compare August 23, 2023 16:57
Signed-off-by: Sam Wheating <samwheating@gmail.com>
@SamWheating SamWheating force-pushed the sw-fix-broken-imports-sync-users branch from 4a0fb46 to 654faca Compare August 23, 2023 16:57
@VictorAtPL
Copy link

Thank you @SamWheating,

I deployed this modified Helm chart version and it's working fine for last 15 minutes. Will continue monitoring.

@giancarloromeo
Copy link

@SamWheating: I tried your patch and it works fine.

@Amar1404
Copy link

Is there any alternative way untill this is implemented.

@khmelevskiy
Copy link

Hello! when is this issue going to be fixed? this prevents our team from updating the airflow :(

@thesuperzapper
Copy link
Member

@SamWheating thanks for this!

I will test with Airflow 2.7 and cut a release with this fix shortly.

@monircefalo
Copy link

Hi @thesuperzapper , i am using Airflow 2.5. still this is happening. Wanted to use Airflow 2.7. Waiting for you fix.
Thanks

@thesuperzapper thesuperzapper added this to the airflow-8.7.2 milestone Aug 28, 2023
@thesuperzapper thesuperzapper changed the title Update User, Role import to support Airflow 2.7.0 fix: sync-users for airflow 2.7.0 Aug 28, 2023
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Aug 28, 2023
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Aug 28, 2023
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Aug 28, 2023
@khmelevskiy
Copy link

hello, please tell me when approximately the merge is planned?

@thesuperzapper thesuperzapper merged commit 773dbf8 into airflow-helm:main Aug 29, 2023
3 checks passed
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Aug 29, 2023
@thesuperzapper
Copy link
Member

@khmelevskiy about 43 minuets ago!

It's in version 8.8.0 of the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
7 participants