feat: support include_deferred in pool sync for airflow 2.7.0
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Einav Daniel <einavd@datricks.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
thesuperzapper
changed the title
include_deferred in pool sync
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
@EinavDanielDX, thanks for this!
I have fixed your implementation in a072d61, and also made it backwards compatible with older airflow versions.
This will be in the next release of the chart.
Issue Triage and PR Tracking
automation
moved this from Unsorted
to PR | Ready to Merge
Aug 28, 2023
|
Great, thanks! |
thesuperzapper
changed the title
include_deferred in pool syncinclude_deferred in pool sync for airflow 2.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
Airflow 2.7.0 added the
include_deferredcolumn to thePoolobject (see apache/airflow#32709), since this column is non-nullable, we must set it.The same as upstream, our default state for
include_deferredisFalse, if not specified.What does your PR do?
Add support for
include_deferredtosync_pools.tplso it will create and update pools successfully.Checklist
For all Pull Requests