Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid pgbouncer-certs volume spec when empty #777

Conversation

thesuperzapper
Copy link
Member

What issues does your PR fix?

What does your PR do?

Some systems which are strict about schema validation will fail if a projected volume does not specify sources.

This PR ensures we only include the pgbouncer-certs volume when it has at least one source.

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.7.2 milestone Aug 28, 2023
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Aug 28, 2023
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Ready to Merge in Issue Triage and PR Tracking Aug 28, 2023
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Aug 28, 2023
@thesuperzapper thesuperzapper merged commit 31dc335 into airflow-helm:main Aug 29, 2023
3 checks passed
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done Aug 29, 2023
@thesuperzapper thesuperzapper deleted the fix-pgbouncer-certs-volume-spec branch August 29, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

invalid pgbouncer-certs volume spec, fails resource validation
1 participant