Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pairing with Kukai blocked #269

Closed
klassare opened this issue Sep 21, 2021 · 3 comments
Closed

Pairing with Kukai blocked #269

klassare opened this issue Sep 21, 2021 · 3 comments
Assignees
@AndreasGassmann @jsamol
Labels
bug Something isn't working

Comments

@klassare
Copy link
Contributor

klassare commented Sep 21, 2021 •
edited

Describe the bug (current behavior)
When pairing with Kukai the new browser tab will be blocked.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.hicetnunc.xyz
  2. Click on "sync" (make sure the page cache is cleared before)
  3. Click on Kukai Wallet" in the list

Expected (correct) behavior
The Beacon SDK shouldn't behave in a way that trigger popup blockers. New tabs must be opened as a direct consequence of the button click.

Screenshots and/or logs
Screenshot_58

Environment

  • Device: Mac
  • OS: Big Sur
  • Browser: Safari (14.1)

Additional context
@klassare klassare added the bug Something isn't working label Sep 21, 2021
@jsamol jsamol self-assigned this Sep 23, 2021
@jsamol
Copy link
Member

jsamol commented Sep 23, 2021

Hi @klassare!
We've just pushed a beta v2.3.3-beta.0 with a fix for this. Can you check it out?

@klassare
Copy link
Contributor Author

This fixed the problem 👍

@jsamol
Copy link
Member

jsamol commented Sep 29, 2021

The fix has been included in v2.3.3.

@jsamol jsamol closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasGassmann AndreasGassmann

@jsamol jsamol

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndreasGassmann @jsamol @klassare