Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the CI happy again #188

Closed
wants to merge 1 commit into from
Closed

Make the CI happy again #188

wants to merge 1 commit into from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 3, 2019

Hi all,

I'd like to propose the following changes:

  • Move from Oracle to OpenJDK completely. Something is off with the Oracle builders of Travis: https://travis-ci.org/airlift/airbase/jobs/592909648
  • Set JDK14 Early Access to allow failure. This will run the build but ignore the result. Therefore the badge on the repository will be green, looking all good won't upset any users. The current issue that we're seeing is spotted by Gradle and Groovy as well and seems to be something with the JDK: JDK 14 support gradle/gradle#10248

Cheers, Fokko

@Fokko Fokko mentioned this pull request Oct 3, 2019
@martint
Copy link
Member

martint commented Oct 5, 2019

Looks good, but can you change the commit message to something more descriptive? (e.g., "Do not report failures for early access JDK")

@Fokko
Copy link
Contributor Author

Fokko commented Oct 5, 2019

Thanks for the response @martint, I've updated the commit message.

@findepi
Copy link
Contributor

findepi commented Oct 5, 2019

@Fokko did you push? (Github doesn't indicate that)

@Fokko
Copy link
Contributor Author

Fokko commented Oct 5, 2019

@findepi My mistake, I've created a PR from my master branch by accident (which I shouldn't). I've opened a PR in #189

@Fokko Fokko closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants