Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jol-core is GPL #119

Closed
omalley opened this issue Jul 15, 2019 · 7 comments
Closed

jol-core is GPL #119

omalley opened this issue Jul 15, 2019 · 7 comments

Comments

@omalley
Copy link

omalley commented Jul 15, 2019

Slice is ASLv2 licensed, but has jol-core as a hard dependency. jol-core is released under the GPL.

Do you have a plan to remove the dependence on jol-core? Is there some workaround to make airlift's zstd compressor work without the GPL code?

@martint
Copy link
Member

martint commented Jul 15, 2019

JOL is licensed under “GPL with classpath exception”, just like all the classes in the JDK. We only use the public APIs in JOL, which are covered by the exception.

@omalley
Copy link
Author

omalley commented Jul 15, 2019

That still leaves it Category X from Apache's point of view, which means that we can't depend on it in Apache projects. Feel free to close this issue if you don't consider it a problem for your users.

@martint
Copy link
Member

martint commented Jul 15, 2019

Ok, let me see how we can break the hard dependency. I’m still surprised it’s an issue for Apache, since that’s the license used by the JDK.

@martint
Copy link
Member

martint commented Jul 18, 2019

BTW, the only reason aircompressor depends on Slice is for the XXHash64 implementation that's used to compute checksums in ZSTD. One possibility is to split out the XXHash64 implementation into a separate project and make it work against byte arrays directly.

@electrum
Copy link
Member

It was fairly easy to extract the parts of XxHash64 that are needed by ZSTD (it only uses the static methods and not the stateful hasher): airlift/aircompressor#100

@omalley
Copy link
Author

omalley commented Oct 23, 2019

Any progress on this one? We hacked around it ORC 1.6, but it is absolutely a hack.

@electrum
Copy link
Member

@omalley aircompressor no longer depends on Slice (and thus JOL) as of release 0.16. (I commented about this on ORC-363 but you probably didn't see it.)

I'm going close this issue since we have no current plans to remove the dependency on JOL in Slice, and I think the actual concern here was aircompressor. If that's not the case, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants