In CI app, clean up launchers on SIGINT or SIGTERM #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SIGINT or SIGTERM is sent to the testem process in CI app, clean up the launchers so that they aren't sitting around afterwords.
|
Noticed on my system that --timeout times out the tests but then the process waits for any launched browsers to quit on their own or be killed by the normal completion of the tests. This adds a test and makes sure timeout leads to a quicker finish. |
| this._boundSigInterrupt = function() { | ||
| this.wrapUp(new Error('Received SIGINT signal')) | ||
| }.bind(this) | ||
| process.on('SIGINT', this._boundSigInterrupt) |
There was a problem hiding this comment.
This is the best place I've figured to put these so far. Happy to move them anywhere.
|
Thank you 👍 |
johanneswuerbach
added a commit
that referenced
this pull request
Apr 25, 2015
In CI app, clean up launchers on SIGINT or SIGTERM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SIGINT or SIGTERM is sent to the testem process in CI app, clean up
the launchers so that they aren't sitting around afterwords.