Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring download_customized_data() #80

Open
Baalmart opened this issue Jul 13, 2020 · 0 comments
Open

Refactoring download_customized_data() #80

Baalmart opened this issue Jul 13, 2020 · 0 comments
Assignees
@Baalmart @danielogen

Comments

@Baalmart
Copy link
Collaborator

  • What were you trying to achieve?
    Ensure that the function implementations are all following the SOLID principles.
  • What are the expected results?
    All implementations following the SOLID principles which indirectly encourages short functions (less than 15 lines).
  • What are the received results?
    A lengthy function....
    The download_customised_data() function in src/analytics/controllers/dashboard.py is very long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baalmart Baalmart

@danielogen danielogen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baalmart @danielogen