Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement airshipctl render command via Kustomize #16

Closed
alexander-hughes opened this issue Feb 10, 2020 · 8 comments
Closed

Implement airshipctl render command via Kustomize #16

alexander-hughes opened this issue Feb 10, 2020 · 8 comments
Assignees
@dukov
Labels
enhancement New feature or request priority/medium Default priority for items sig/yaml Relates to the YAML special interest group. wip Work in progress
Projects
Airship 2.0
Milestone
betav1

Comments

@alexander-hughes
Copy link
Contributor

Problem description (if applicable)
Airshipctl needs the ability to render documents for a site.

Proposed change
Implement airshipctl render command as a document CLI command. This should be done using Kustomize for rendering.

Potential impacts
None.
@alexander-hughes alexander-hughes added the enhancement New feature or request label Feb 10, 2020
@drewwalters96
Copy link
Contributor

@dukov is working on this

Gerrit link

@drewwalters96 drewwalters96 added component/document sig/yaml Relates to the YAML special interest group. labels Feb 10, 2020
@drewwalters96 drewwalters96 added this to To do in Airship 2.0 via automation Feb 10, 2020
@dukov
Copy link
Member

dukov commented Feb 12, 2020

https://review.opendev.org/#/c/697327
https://review.opendev.org/#/c/705016
https://review.opendev.org/#/c/698658

@ianpittwood ianpittwood added the ready for review Change related to the issue is ready for review label Feb 17, 2020
@ian-howell ian-howell moved this from To do to Submitted on Gerrit in Airship 2.0 Feb 18, 2020
Airship 2.0 automation moved this from Submitted on Gerrit to Done Feb 18, 2020
airshipbot pushed a commit that referenced this issue Feb 18, 2020
@dukov
Add render sub-command frame
ff917e5 
Render command filters documents and prints them to user-defined
output in a form of multi-document YAML.

Sub-command receives following document filter flags:
 * label
 * annotation
 * apiVersion (a.k.a group-version)
 * kind
 * filter

Related: #16
Change-Id: I7efb0a478e1070efd1791ab10d7c3946c8c28630
dukov added a commit to dukov/airshipctl that referenced this issue Feb 26, 2020
@dukov
Add expression based filter for document bundle
7e57c15 
Filter evaluates logical expression written in Go format. This
expression filters documents out from bundle. For example filter
'spec.image == "ubuntu:xenial" && metadata.label.app == "helm"' will
return all documents which have values referenced by JSON path specified
in the expression.

Related: airshipit#15
Related: airshipit#16
Change-Id: I5881f80680863d18f35175eaed5f9d54d8a94e80
dukov added a commit to dukov/airshipctl that referenced this issue Feb 26, 2020
@dukov
[WIP] Implement document rendering sub-command
1bb7825 
Kustomize filtering and rendering mechanisms are used.

Related: airshipit#14
Related: airshipit#15
Related: airshipit#16
Change-Id: Ied06b95577772cc51f51f3ebb3acd441388d5cda
@seaneagan
Copy link
Contributor

Looks like there is something very similar on the way upstream in kustomize:

https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/tutorials/configuration-basics.md#grep----search-for-resources-by-field-values

@ian-howell
Copy link
Contributor

Looks like I may have closed this too early. kustomize grep seems really useful. Incorporating it into airshipctl not only reduces the size of our codebase, but also aligns with our stance of investing more in community tools

@ian-howell ian-howell reopened this Mar 3, 2020
Airship 2.0 automation moved this from Done to In progress Mar 3, 2020
@dukov
Copy link
Member

dukov commented Mar 4, 2020

This is an excellent feature and we definitely need to incorporate it!
The only issue i see is we'd have to rework document module since this 'config grep' is implemented in latest version of kustomize which does not expose functions that are used

@jezogwza jezogwza added the triage Needs evaluation by project members label Mar 4, 2020
@airshipbot airshipbot added wip Work in progress and removed ready for review Change related to the issue is ready for review labels Mar 5, 2020
@airshipbot
Copy link

New Related Change

Link: https://review.opendev.org/711487
Subject: [WIP]Add document rendering sub-command
Authored By: Dmitry Ukov (dukov@mirantis.com)

@jezogwza jezogwza added this to the betav1 milestone Mar 11, 2020
@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Mar 11, 2020
@jezogwza jezogwza mentioned this issue May 13, 2020
Closed
airshipbot pushed a commit that referenced this issue May 27, 2020
@dukov @raliev12
Implement document rendering sub-command
6d05ae6 
Kustomize filtering and rendering mechanisms are used.

Related: #14
Related: #15
Related: #16
Relates-To: #247
Closes: #247
Co-authored-by: Ruslan Aliev <raliev@mirantis.com>
Change-Id: Ied06b95577772cc51f51f3ebb3acd441388d5cda
@eak13
Copy link

eak13 commented Jun 25, 2020

@dukov with moving render to the phase command, should we close this issue out? Thanks

@dukov
Copy link
Member

dukov commented Jun 29, 2020

Yes. Let's close it.

@dukov dukov closed this as completed Jun 29, 2020
Airship 2.0 automation moved this from In progress to Done Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dukov dukov

Labels
enhancement New feature or request priority/medium Default priority for items sig/yaml Relates to the YAML special interest group. wip Work in progress
Projects
Airship 2.0
  
Done
Milestone
betav1
Development

No branches or pull requests
9 participants
@seaneagan @dukov @eak13 @jezogwza @drewwalters96 @ianpittwood @ian-howell @alexander-hughes @airshipbot